Paths

Table of Contentst

-
nix/
1
start-powerline.sh

[Nix] Only prompt Powerline when an interactive shell
ClosedPublic
Actions

Authored by • jon on Aug 22 2022, 4:58 PM.

Details

Reviewers

atul
• abosh

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMd0abaae7b16d: [Nix] Only prompt Powerline when an interactive shell

Summary

Buildkite CI was polling indefinitely when running nix develop.

Only ask for powerline prompt if it's an interactive shell.

https://linear.app/comm/issue/ENG-1684

Test Plan

# Reset powerline preference
rm ~/Library/Caches/app.comm/enable-powerline

nix develop
# Should get prompted for Powerline

For buildkite, the below run should pass
https://buildkite.com/comm/blob-nix/builds/50#0182c7f4-63c8-407c-a17a-3852aa3ae46b

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/fix-prompt-ci

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 22 2022, 4:58 PM

Owners added a reviewer: Restricted Owners Package.Aug 22 2022, 4:58 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2022, 4:58 PM

Harbormaster completed remote builds in B11519: Diff 15841.Aug 22 2022, 5:08 PM

• jon requested review of this revision.Aug 22 2022, 5:08 PM

Nice, looks like the Buildkite CI passes as well.

nix/start-powerline.sh
6
7	I think this looks cleaner haha because it matches the rest of the line and we use it in other spots in the codebase.

This revision is now accepted and ready to land.Aug 22 2022, 6:29 PM

Lint

• jon marked 2 inline comments as done.Aug 23 2022, 9:09 AM

Harbormaster completed remote builds in B11546: Diff 15875.Aug 23 2022, 9:20 AM

Closed by commit rCOMMd0abaae7b16d: [Nix] Only prompt Powerline when an interactive shell (authored by • jon). · Explain WhyAug 23 2022, 9:36 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMd0abaae7b16d: [Nix] Only prompt Powerline when an interactive shell.

Revision Contents
Changeset List

Path

Size

nix/

start-powerline.sh

8 lines

Diff 15841

View Options

nix/start-powerline.sh

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines	async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult;		let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult;		const [, canRequestPermission] = permissionPromisesResult;

if (!hasPermission && canRequestPermission) {		if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => {		const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt		// We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears		// doesn't appear immediately but after logged-out modal disappears
await sleep(10);		await sleep(10);
await this.requestAndroidNotificationsPermission();		return await this.requestAndroidNotificationsPermission();
		marcinUnsubmitted Not Done Inline Actions We definitely should return something from this lambda since otherwise it is useless to assign it to variable. When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android. If we find that we don't have permissions then just calling `await this.requestAndroidNotificationsPermission();` would result in a prompt asking for notifications permissions. However if the user grants those permissions then `hasPermissions` is still falsy (since promise returned nothing), so `deviceToken` will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render. This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state. marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})();		})();
hasPermission = permissionResponse;		hasPermission = permissionResponse;
}		}

if (!hasPermission) {		if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);		this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return;		return;
}		}
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines

[Nix] Only prompt Powerline when an interactive shellClosedPublicActions