Page MenuHomePhabricator
Differential D4949

[services] Tunnelbroker - Add copying of the shared directory to the Dockerfile
ClosedPublic
Actions

Authored by • max on Aug 24 2022, 4:58 PM.
Tags
None
Referenced Files
F3269888: D4949.diff
Sat, Nov 16, 4:12 AM
Unknown Object (File)
Tue, Nov 5, 9:10 AM
Unknown Object (File)
Wed, Oct 23, 9:59 AM
Unknown Object (File)
Mon, Oct 21, 12:25 PM
Unknown Object (File)
Fri, Oct 18, 7:54 AM
Unknown Object (File)
Thu, Oct 17, 10:47 AM
Unknown Object (File)
Thu, Oct 17, 10:47 AM
Unknown Object (File)
Thu, Oct 17, 10:47 AM
View All Files
Subscribers
• abosh
ashoat
atul
• karol
tomek

Details

Reviewers
• karol
tomek
• jon
Commits
rCOMM8af45cc98819: [services] Tunnelbroker - Add copying of the shared directory to the Dockerfile
Summary

This diff introduces changes to the Dockerfile to copy the /shared directory to the service Docker container.
In a ENG-1698 we have introduced a new directory for the shared objects.

To make the Tunnelbroker built in D4807 and beyond updates, we need to copy the /shared folder to the Docker container.

Related Linear tasks: ENG-1698, ENG-1672

Test Plan

Successfully built in a D4807 using the cmake/corrosion-cxx.cmake file from the shared directory.

Diff Detail

Repository
rCOMM Comm
Branch
add-copy-of-shared-docker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Aug 24 2022, 4:58 PM
• max held this revision as a draft.
Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptAug 24 2022, 4:58 PM
• max updated this revision to Diff 15946.Aug 24 2022, 5:01 PM

Adding D4805 to the stack.

Harbormaster failed remote builds in B11597: Diff 15945!Aug 24 2022, 5:03 PM
Harbormaster failed remote builds in B11598: Diff 15946!Aug 24 2022, 5:05 PM
• max edited the summary of this revision. (Show Details)Aug 24 2022, 5:06 PM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max updated this revision to Diff 15947.Aug 24 2022, 5:10 PM

Fixing path.

• max added a parent revision: D4805: [services] Add CMake file with functions for Corrosion and CXX integration.Aug 24 2022, 5:11 PM
Harbormaster completed remote builds in B11599: Diff 15947.Aug 24 2022, 5:18 PM
• max mentioned this in D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 24 2022, 5:19 PM
• max added a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 24 2022, 5:21 PM
• max edited the summary of this revision. (Show Details)
• max published this revision for review.Aug 24 2022, 5:28 PM
• max added a reviewer: • jon.
• karol accepted this revision.Aug 26 2022, 6:35 AM
tomek accepted this revision.Aug 26 2022, 10:05 AM
This revision is now accepted and ready to land.Aug 26 2022, 10:05 AM
Closed by commit rCOMM8af45cc98819: [services] Tunnelbroker - Add copying of the shared directory to the Dockerfile (authored by • max). · Explain WhyAug 29 2022, 5:47 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM8af45cc98819: [services] Tunnelbroker - Add copying of the shared directory to the Dockerfile.
• max removed a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 29 2022, 5:48 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
1 line

Diff 15947

View Options

services/tunnelbroker/Dockerfile

Loading...