Page MenuHomePhabricator
Differential D4959

[native] added react-native-webview to support SIWE
ClosedPublic
Actions

Authored by • derek on Aug 26 2022, 9:05 AM.
Tags
None
Referenced Files
F5252636: D4959.diff
Sun, Apr 6, 5:21 AM
Unknown Object (File)
Fri, Apr 4, 2:07 PM
Unknown Object (File)
Fri, Apr 4, 2:07 PM
Unknown Object (File)
Fri, Apr 4, 2:07 PM
Unknown Object (File)
Tue, Apr 1, 12:00 PM
Unknown Object (File)
Tue, Apr 1, 12:00 PM
Unknown Object (File)
Tue, Apr 1, 12:00 PM
Unknown Object (File)
Sat, Mar 22, 3:08 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jacek
tomek
varun

Details

Reviewers
atul
ashoat
• abosh
Commits
rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE
Summary

added react-native-webview to support sign in with ethereum on native. related linear task - parent SIWE task

Test Plan

compile/run comm with xcode to ensure adding webview didn't break anything

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-native-webview
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Aug 26 2022, 9:05 AM
• derek edited the summary of this revision. (Show Details)Aug 26 2022, 9:06 AM
Harbormaster completed remote builds in B11639: Diff 16006.Aug 26 2022, 9:16 AM
• derek requested review of this revision.Aug 26 2022, 9:16 AM
• derek updated this revision to Diff 16010.Aug 26 2022, 9:39 AM

Updating D4959: rebased on top of master

Harbormaster completed remote builds in B11643: Diff 16010.Aug 26 2022, 9:48 AM
• abosh resigned from this revision.Aug 26 2022, 10:02 AM

Resigning since I don't have much context on adding new dependencies. But nice adding @ashoat here as a first-pass reviewer since he should take a look at all new dependencies!

ashoat accepted this revision.Aug 26 2022, 12:04 PM
This revision is now accepted and ready to land.Aug 26 2022, 12:04 PM
Closed by commit rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE (authored by • derek). · Explain WhyAug 29 2022, 11:10 AM
This revision was automatically updated to reflect the committed changes.
• derek added a commit: rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE.

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines
1 line
20 lines

Diff 16010

View Options

native/ios/Podfile.lock

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

native/package.json

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

yarn.lock

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines