Page MenuHomePhabricator
Differential D4959

[native] added react-native-webview to support SIWE
ClosedPublic
Actions

Authored by • derek on Aug 26 2022, 9:05 AM.
Tags
None
Referenced Files
F3764568: D4959.id16080.diff
Sat, Jan 11, 1:25 PM
F3764567: D4959.id16010.diff
Sat, Jan 11, 1:25 PM
F3764566: D4959.id.diff
Sat, Jan 11, 1:25 PM
Unknown Object (File)
Sun, Jan 5, 3:26 PM
Unknown Object (File)
Sun, Jan 5, 3:26 PM
Unknown Object (File)
Sun, Jan 5, 3:26 PM
Unknown Object (File)
Sun, Jan 5, 3:25 PM
Unknown Object (File)
Sun, Jan 5, 3:22 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jacek
tomek
varun

Details

Reviewers
atul
ashoat
• abosh
Commits
rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE
Summary

added react-native-webview to support sign in with ethereum on native. related linear task - parent SIWE task

Test Plan

compile/run comm with xcode to ensure adding webview didn't break anything

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-native-webview
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Aug 26 2022, 9:05 AM
• derek edited the summary of this revision. (Show Details)Aug 26 2022, 9:06 AM
Harbormaster completed remote builds in B11639: Diff 16006.Aug 26 2022, 9:16 AM
• derek requested review of this revision.Aug 26 2022, 9:16 AM
• derek updated this revision to Diff 16010.Aug 26 2022, 9:39 AM

Updating D4959: rebased on top of master

Harbormaster completed remote builds in B11643: Diff 16010.Aug 26 2022, 9:48 AM
• abosh resigned from this revision.Aug 26 2022, 10:02 AM

Resigning since I don't have much context on adding new dependencies. But nice adding @ashoat here as a first-pass reviewer since he should take a look at all new dependencies!

ashoat accepted this revision.Aug 26 2022, 12:04 PM
This revision is now accepted and ready to land.Aug 26 2022, 12:04 PM
Closed by commit rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE (authored by • derek). · Explain WhyAug 29 2022, 11:10 AM
This revision was automatically updated to reflect the committed changes.
• derek added a commit: rCOMM75437d1e9f83: [native] added react-native-webview to support SIWE.

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines
1 line
20 lines

Diff 16010

View Options

native/ios/Podfile.lock

Loading...
View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...