Page MenuHomePhabricator
Differential D4964

[landing] revert changes in D4510
AbandonedPublic
Actions

Authored by • derek on Aug 26 2022, 2:45 PM.
Tags
None
Referenced Files
F3364955: D4964.diff
Mon, Nov 25, 5:59 AM
Unknown Object (File)
Fri, Nov 22, 7:50 PM
Unknown Object (File)
Fri, Nov 22, 10:03 AM
Unknown Object (File)
Fri, Nov 22, 10:03 AM
Unknown Object (File)
Fri, Nov 22, 10:02 AM
Unknown Object (File)
Fri, Nov 22, 7:30 AM
Unknown Object (File)
Mon, Oct 28, 2:16 PM
Unknown Object (File)
Oct 23 2024, 10:00 AM
View All 95 Files
Subscribers
• abosh
ashoat
atul
• jacek
tomek

Details

Reviewers
• abosh
atul
ashoat
Summary

temporarily commenting out SIWE while we get to the bottom of the cool looking issue caused by rainbowkit
before:

image.png (1×1 px, 1 MB)

after:
image.png (1×1 px, 1 MB)

context in thread

Test Plan

ran it before commenting and after. fixes CSS issue

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-webview
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Aug 26 2022, 2:45 PM
• derek edited the summary of this revision. (Show Details)Aug 26 2022, 2:45 PM
• derek attached a referenced file: F150487: image.png. (Show Details)
• derek attached a referenced file: F150486: image.png. (Show Details)
Harbormaster completed remote builds in B11652: Diff 16026.Aug 26 2022, 2:57 PM
• derek requested review of this revision.Aug 26 2022, 2:57 PM
• abosh requested changes to this revision.Aug 26 2022, 3:15 PM

Hmm...your before and after pics are mine. I didn't test this diff. Additionally, the after pic is just the current state of https://comm.app/, our public facing landing page. This diff broke in dev, not prod.

You should incorporate these changes, and show that the fix works with these changes.

This revision now requires changes to proceed.Aug 26 2022, 3:15 PM
ashoat added a comment.Aug 26 2022, 8:30 PM

Please don't comment things out. If the diff broke master it just be reverted, not commented out

• derek abandoned this revision.Aug 27 2022, 10:50 AM

Revision Contents
Changeset List

PathSize
landing/
3 lines
14 lines
87 lines

Diff 16026

View Options

landing/landing.react.js

Loading...
View Options

landing/root.js

Loading...
View Options

landing/siwe.react.js

Loading...