Page MenuHomePhabricator
Differential D4991

[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
ClosedPublic
Actions

Authored by atul on Aug 30 2022, 3:04 PM.
Tags
None
Referenced Files
F3342094: D4991.diff
Fri, Nov 22, 12:29 AM
Unknown Object (File)
Sat, Nov 16, 8:39 AM
Unknown Object (File)
Mon, Nov 11, 2:51 AM
Unknown Object (File)
Sat, Nov 9, 6:59 AM
Unknown Object (File)
Fri, Nov 8, 8:02 AM
Unknown Object (File)
Sat, Nov 2, 1:13 PM
Unknown Object (File)
Sat, Nov 2, 1:13 PM
Unknown Object (File)
Sat, Nov 2, 1:13 PM
View All Files
Subscribers
None

Details

Reviewers
• abosh
• jacek
tomek
ashoat
Commits
rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`
Summary

Introduced these in previous diff (D4990).

Just some basic tests mostly as a sanity check for myself since I have minimal experience with tcomb.

Test Plan

Run these tests (they're included in CI as well)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D4991 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul updated this revision to Diff 16122.Aug 30 2022, 3:04 PM
atul created this revision.

fix typo

atul published this revision for review.Aug 30 2022, 3:06 PM
Harbormaster completed remote builds in B11731: Diff 16121.Aug 30 2022, 3:14 PM
Harbormaster completed remote builds in B11732: Diff 16122.
• abosh edited the summary of this revision. (Show Details)Aug 30 2022, 10:13 PM
tomek accepted this revision.Aug 31 2022, 4:38 AM
This revision is now accepted and ready to land.Aug 31 2022, 4:38 AM
• abosh accepted this revision.Aug 31 2022, 9:35 AM
atul updated this revision to Diff 16141.Aug 31 2022, 11:39 AM

rebase around other diffs before landing

This revision was landed with ongoing or failed builds.Aug 31 2022, 11:41 AM
Closed by commit rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7ff483ad02d6: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.
Harbormaster completed remote builds in B11746: Diff 16141.Aug 31 2022, 11:47 AM
atul added a reverting change: rCOMM39367c357963: Revert "[lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`".Aug 31 2022, 12:40 PM
atul reopened this revision.Aug 31 2022, 12:46 PM
This revision is now accepted and ready to land.Aug 31 2022, 12:46 PM
Closed by commit rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]` (authored by atul). · Explain WhyAug 31 2022, 12:48 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8c6cd24f7823: [lib] Introduce tests for `tMediaMessage[Photo/Video/Media]`.

Revision Contents
Changeset List

PathSize
lib/
utils/
115 lines

Diff 16141

View Options

lib/utils/validation-utils.test.js

Loading...