Differential D4990
[lib] Introduce `tMediaMessage[Photo/Video/Media]` to validate requests to `textMessageCreationResponder` Authored by atul on Aug 30 2022, 3:04 PM. Tags None Referenced Files
Subscribers None
Details
We're modifying textMessageCreationResponder to be able to accept a list of MediaMessageServerDBContents as one of the arguments. Before we build the new validator for textMessageCreationResponder we introduce these basic types that we will build upon in subsequent diffs. Depends on D4985 Will add tests in next diff
Diff Detail
Event Timeline
Comment Actions Read up on tcomb since I had never heard of it before, but still sort of unsure why we need these. Is it because tcomb checks types at runtime and Flow is static? This diff makes sense according to the documentation of tcomb, however, and matches the spec'd design laid out in D4982's diff summary.
Comment Actions Was getting the following import issue: [NODEM] file:///Users/atul/comm/keyserver/dist/lib/utils/validation-utils.js:1
[NODEM] import t, { TUnion } from 'tcomb';
[NODEM] ^^^^^^
[NODEM] SyntaxError: Named export 'TUnion' not found. The requested module 'tcomb' is a CommonJS module, which may not support all module.exports as named exports.
[NODEM] CommonJS modules can always be imported via the default export, for example using:
[NODEM]
[NODEM] import pkg from 'tcomb';
[NODEM] const { TUnion } = pkg;
[NODEM]
[NODEM] at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
[NODEM] at async ModuleJob.run (node:internal/modules/esm/module_job:179:5)
[NODEM] at async Loader.import (node:internal/modules/esm/loader:178:24)
[NODEM] at async Object.loadESM (node:internal/process/esm_loader:68:5)
[NODEM] at async handleMainPromise (node:internal/modules/run_main:63:12)
[NODEM] [nodemon] app crashed - waiting for file changes before starting... | ||||||||||||||||||||||||||||||||||||||||||||||||