Details

Reviewers

• abosh
tomek
marcin

Commits

rCOMMa7ba71744ae8: Revert "[lib] Update `SendMultimediaMessageRequest` type"
rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload

Summary

Need to include the thumbnailID in addition to the thumbnailURL in the updateMediaPayload.

Depends on D5059

Test Plan

sendMultimediaMessage in subsequent diff gets correctly constructed mediaMessageContents with expected values.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 6 2022, 4:18 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 6 2022, 4:18 AM

Harbormaster completed remote builds in B11898: Diff 16341.Sep 6 2022, 4:27 AM

atul requested review of this revision.Sep 6 2022, 4:27 AM

atul added a child revision: D5061: [lib] Update `SendMultimediaMessageRequest` type.Sep 6 2022, 4:42 AM

atul edited the test plan for this revision. (Show Details)Sep 6 2022, 4:43 AM

ignore

Harbormaster completed remote builds in B11938: Diff 16389.Sep 7 2022, 1:19 AM

Harbormaster completed remote builds in B11939: Diff 16390.Sep 7 2022, 1:22 AM

atul removed a reviewer: • jacek.Sep 8 2022, 12:34 AM

atul added 1 blocking reviewer(s): tomek.Sep 8 2022, 5:22 AM

tomek accepted this revision.Sep 8 2022, 3:07 PM

This revision is now accepted and ready to land.Sep 8 2022, 3:07 PM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 8 2022, 8:57 PM

Closed by commit rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload.

Harbormaster completed remote builds in B12024: Diff 16519.Sep 8 2022, 9:06 PM

atul added a commit: rCOMMa7ba71744ae8: Revert "[lib] Update `SendMultimediaMessageRequest` type".Sep 9 2022, 9:28 AM

[native] Update `thumbnailID` upon successful thumbnail upload
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16520

native/input/input-state-container.react.js

[native] Update `thumbnailID` upon successful thumbnail uploadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16520

native/input/input-state-container.react.js

[native] Update `thumbnailID` upon successful thumbnail upload
ClosedPublic
Actions

Revision Contents
Changeset List