Page MenuHomePhabricator
Differential D5060

[native] Update `thumbnailID` upon successful thumbnail upload
ClosedPublic
Actions

Authored by atul on Sep 5 2022, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 2:12 PM
Unknown Object (File)
Thu, Mar 13, 7:39 AM
Unknown Object (File)
Wed, Mar 12, 5:39 AM
Unknown Object (File)
Tue, Mar 11, 3:38 PM
Unknown Object (File)
Sat, Mar 8, 1:05 AM
Unknown Object (File)
Sat, Mar 8, 1:05 AM
Unknown Object (File)
Sat, Mar 8, 1:05 AM
Unknown Object (File)
Sat, Mar 8, 1:05 AM
View All Files
Subscribers
ashoat

Details

Reviewers
• abosh
tomek
marcin
Commits
rCOMMa7ba71744ae8: Revert "[lib] Update `SendMultimediaMessageRequest` type"
rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload
Summary

Need to include the thumbnailID in addition to the thumbnailURL in the updateMediaPayload.

Depends on D5059

Test Plan

sendMultimediaMessage in subsequent diff gets correctly constructed mediaMessageContents with expected values.

Screen Shot 2022-09-06 at 12.26.19 AM.png (692×2 px, 855 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Sep 5 2022, 9:18 PM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2022, 9:18 PM
Harbormaster completed remote builds in B11898: Diff 16341.Sep 5 2022, 9:27 PM
atul requested review of this revision.Sep 5 2022, 9:27 PM
atul added a child revision: D5061: [lib] Update `SendMultimediaMessageRequest` type.Sep 5 2022, 9:42 PM
atul edited the test plan for this revision. (Show Details)Sep 5 2022, 9:43 PM
atul updated this revision to Diff 16389.Sep 6 2022, 6:09 PM

ignore

atul updated this revision to Diff 16390.Sep 6 2022, 6:11 PM

ignore

Harbormaster completed remote builds in B11938: Diff 16389.Sep 6 2022, 6:19 PM
Harbormaster completed remote builds in B11939: Diff 16390.Sep 6 2022, 6:22 PM
atul removed a reviewer: • jacek.Sep 7 2022, 5:34 PM
atul added 1 blocking reviewer(s): tomek.Sep 7 2022, 10:22 PM
tomek accepted this revision.Sep 8 2022, 8:07 AM
This revision is now accepted and ready to land.Sep 8 2022, 8:07 AM
atul updated this revision to Diff 16519.Sep 8 2022, 1:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 8 2022, 1:57 PM
Closed by commit rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7ed99628ce2f: [native] Update `thumbnailID` upon successful thumbnail upload.
Harbormaster completed remote builds in B12024: Diff 16519.Sep 8 2022, 2:06 PM
atul added a commit: rCOMMa7ba71744ae8: Revert "[lib] Update `SendMultimediaMessageRequest` type".Sep 9 2022, 2:28 AM

Revision Contents
Changeset List

PathSize
native/
input/
3 lines

Diff 16390

View Options

native/input/input-state-container.react.js

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines "dependencies": {
"sharp": "^0.30.5", "sharp": "^0.30.5",
"siwe": "^1.1.6", "siwe": "^1.1.6",
"sql-template-strings": "^2.2.2", "sql-template-strings": "^2.2.2",
"stream-combiner": "^0.2.2", "stream-combiner": "^0.2.2",
"tcomb": "^3.2.29", "tcomb": "^3.2.29",
"twin-bcrypt": "^2.1.1", "twin-bcrypt": "^2.1.1",
"uuid": "^3.3.3", "uuid": "^3.3.3",
"web": "0.0.1", "web": "0.0.1",
"web-push": "^3.5.0" "web-push": "^3.5.0",
"ws": "^8.13.0"
ashoatUnsubmitted
Done
Inline Actions

Realizing this will change the version of ws that is imported here. In fact we're already importing a newer version (7.5.9) than our version of express-ws uses (5.2.3), but it looks like we only use it for Flow types so it's okay

ashoat: Realizing this will change the version of `ws` that is imported [here](https://github.
}, },
"optionalDependencies": { "optionalDependencies": {
"bufferutil": "^4.0.5", "bufferutil": "^4.0.5",
"utf-8-validate": "^5.0.7" "utf-8-validate": "^5.0.7"
}, },
"nodemonConfig": { "nodemonConfig": {
"delay": "200" "delay": "200"
}, },
Show All 15 Lines