[services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database method
ClosedPublic
Actions

Authored by • max on Sep 16 2022, 11:55 AM.

Details

Reviewers

• jon
tomek
• karol

Commits

rCOMMf6cc2d93dede: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database…

Summary

This diff introduces a test for the updateSessionItemIsOnline method from D5165.

In this test, we will create a SessionItem entity and push it to the DynamoDB table. The default value for the IsOnline (D5164) field is false. We are checking the default value and updating it to true using the updateSessionItemIsOnline method and checking the value to become true after.

Related Linear task: ENG-1766

Test Plan

Successfully built.
The test was successfully passed.

Diff Detail

Repository

rCOMM Comm

Branch

add-test-for-updateisonline

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Sep 16 2022, 11:55 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 16 2022, 11:55 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald Transcript

Harbormaster completed remote builds in B12228: Diff 16776.Sep 16 2022, 12:04 PM

• max added a parent revision: D5165: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method.Sep 16 2022, 12:08 PM

• max mentioned this in D5164: [services] Tunnelbroker - Update `SessionItem` database entity with the `IsOnline` field.Sep 16 2022, 12:18 PM

• max mentioned this in D5165: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method.Sep 16 2022, 12:21 PM

• max published this revision for review.Sep 16 2022, 12:25 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: tomek.

Herald added a reviewer: • karol. · View Herald TranscriptSep 16 2022, 12:26 PM

Unfortunately, I don't have integration tests added yet, see https://phab.comm.dev/D5164#151290 .

tomek accepted this revision.Sep 19 2022, 6:09 AM

This revision is now accepted and ready to land.Sep 19 2022, 6:09 AM

Rebased on parent changes.

In D5166#151293, @jon wrote:

Unfortunately, I don't have integration tests added yet, see https://phab.comm.dev/D5164#151290 .

related: https://linear.app/comm/issue/ENG-1814/distinguish-between-unit-and-integration-tests-for-tunnelbroker

Yes, at the moment it can be tested using Docker by calling: yarn run-unit-tests, yarn run-integration-tests (using localstack and rabbitmq Docker images).

Harbormaster completed remote builds in B12313: Diff 16901.Sep 20 2022, 6:01 AM

Closed by commit rCOMMf6cc2d93dede: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database… (authored by • max). · Explain WhySep 20 2022, 6:19 AM

This revision was automatically updated to reflect the committed changes.

• max mentioned this in rCOMMe4f0d2ebe260: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method.

• max added a commit: rCOMMf6cc2d93dede: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database….

• max mentioned this in D5175: [services] Tunnelbroker - Update device online status in `Get` handler.Sep 21 2022, 6:46 AM