[native] disable forceDarkAllowed on android
ClosedPublic
Actions

Authored by michal on Sep 20 2022, 5:50 AM.

Details

Reviewers

tomek
atul
• abosh
ashoat

Commits

rCOMM0713e6cb0903: [native] disable forceDarkAllowed on android

Summary

https://linear.app/comm/issue/ENG-1835/inline-code-in-messages-is-unreadable-on-android-with-a-forced-dark
Disables forceDarkAllowed option because markdown inline code would display incorrectly.

Test Plan

Check if inline code displays correctly. Check if there are any unexpected changes in the rest of the app.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 20 2022, 5:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2022, 5:50 AM

Harbormaster completed remote builds in B12312: Diff 16900.Sep 20 2022, 6:00 AM

michal requested review of this revision.Sep 20 2022, 6:00 AM

ashoat accepted this revision.Sep 20 2022, 6:10 AM

This revision is now accepted and ready to land.Sep 20 2022, 6:10 AM

Closed by commit rCOMM0713e6cb0903: [native] disable forceDarkAllowed on android (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 21 2022, 3:14 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM0713e6cb0903: [native] disable forceDarkAllowed on android.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

res/

values/

styles.xml

1 line

Diff 16940

View Options

native/android/app/src/main/res/values/styles.xml

[native] disable forceDarkAllowed on androidClosedPublicActions