Page MenuHomePhabricator
Differential D5224

[landing] added sideEffects to solve node_module CSS (rainbowkit) not being added in production
ClosedPublic
Actions

Authored by • derek on Sep 23 2022, 11:11 AM.
Tags
None
Referenced Files
F3347257: D5224.diff
Fri, Nov 22, 11:31 AM
Unknown Object (File)
Sun, Nov 10, 10:40 PM
Unknown Object (File)
Tue, Nov 5, 7:17 AM
Unknown Object (File)
Sun, Nov 3, 1:19 PM
Unknown Object (File)
Oct 20 2024, 3:40 AM
Unknown Object (File)
Oct 15 2024, 1:53 AM
Unknown Object (File)
Oct 15 2024, 1:39 AM
Unknown Object (File)
Oct 13 2024, 12:06 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek
varun

Details

Reviewers
atul
varun
• abosh
ashoat
Commits
rCOMM999e6100365e: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being…
Summary

RainbowKit's CSS doesn't get bundled in production, because the way they're exposing it is with a sideEffect. Webpack's side effects are basically an infinite black hole, as denoted by this issue that's been open for 4.5 years. more context/explanation on this stack overflow answer

Test Plan

run yarn prod in landing with this diff and RainbowKit experience found on localhost/commlanding/siwe now has more than 0 styles

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Sep 23 2022, 11:11 AM
Herald added a subscriber: tomek. · View Herald TranscriptSep 23 2022, 11:11 AM
• derek edited the summary of this revision. (Show Details)Sep 23 2022, 11:13 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2022, 11:13 AM
Harbormaster failed remote builds in B12415: Diff 17035!
• derek edited the test plan for this revision. (Show Details)Sep 23 2022, 11:14 AM
• derek edited the summary of this revision. (Show Details)
• derek edited the summary of this revision. (Show Details)Sep 23 2022, 11:20 AM
• derek edited the summary of this revision. (Show Details)
• derek updated this revision to Diff 17044.Sep 23 2022, 11:32 AM

moved sideEffects to where it belongs

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2022, 11:34 AM
Harbormaster failed remote builds in B12417: Diff 17044!
• derek updated this revision to Diff 17045.Sep 23 2022, 11:37 AM

cleaned up some accidental additions

Harbormaster completed remote builds in B12418: Diff 17045.Sep 23 2022, 11:47 AM
• derek requested review of this revision.Sep 23 2022, 11:47 AM
ashoat requested changes to this revision.Sep 23 2022, 11:50 AM
ashoat added inline comments.
lib/webpack/shared.cjs
138 ↗(On Diff #17045)

I initially added it here. My thinking was that we're scoping the change to apply to just the case where it matters – CSS files being imported from node_modules on prod.

What are the pros / cons of placing it here vs. where you placed it?

This revision now requires changes to proceed.Sep 23 2022, 11:50 AM
• derek updated this revision to Diff 17050.Sep 23 2022, 11:53 AM

final resting place of sideEffects: true

Harbormaster completed remote builds in B12420: Diff 17050.Sep 23 2022, 12:01 PM
• derek marked an inline comment as done.Sep 23 2022, 12:44 PM
• derek added inline comments.
lib/webpack/shared.cjs
138 ↗(On Diff #17045)

i moved it back there, i think scoping to where it matters makes more sense

ashoat accepted this revision.Sep 23 2022, 12:54 PM
This revision is now accepted and ready to land.Sep 23 2022, 12:54 PM
Closed by commit rCOMM999e6100365e: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being… (authored by • derek). · Explain WhySep 26 2022, 7:24 AM
This revision was automatically updated to reflect the committed changes.
• derek marked an inline comment as done.
• derek added a commit: rCOMM999e6100365e: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being….

Revision Contents
Changeset List

PathSize
lib/
webpack/
1 line

Diff 17050

View Options

lib/webpack/shared.cjs

Loading...