Page MenuHomePhabricator

[keyserver] allow `source` field in log_in endpoint validation
ClosedPublic

Authored by kamil on Sep 26 2022, 6:46 AM.
Tags
None
Referenced Files
F3353482: D5227.id17163.diff
Sat, Nov 23, 9:58 AM
F3352648: D5227.diff
Sat, Nov 23, 6:47 AM
Unknown Object (File)
Fri, Nov 22, 9:10 AM
Unknown Object (File)
Fri, Nov 22, 9:10 AM
Unknown Object (File)
Fri, Nov 22, 9:10 AM
Unknown Object (File)
Fri, Nov 22, 9:09 AM
Unknown Object (File)
Fri, Nov 22, 9:07 AM
Unknown Object (File)
Sun, Nov 10, 3:40 PM

Details

Summary

We will need to pass the source field to the keyserver to distinguish between different log-in scenarios (task).
This diff adds this field to the strict interface but allows an undefined source (which will happens on logging from the login form).
A proper type for login from form will be added later on and this field will become mandatory.

Test Plan
  1. Modify the code to pass the source field.
  2. Check if validation pass for both undefined (e.g. login from form) and defined source (e.g. cookie expired).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)
kamil added reviewers: atul, abosh.
This revision is now accepted and ready to land.Sep 27 2022, 8:39 AM

I think the LogInRequest type should've also been updated, but that can be done in a later diff.