ENG-1827
Makes sure that both ios and android use the same logic for determining whether the thread settings should be accessible.
Details
Details
Test on both android and ios
- Start creating a new thread, the settings should be unavailable
- Add new users, send a message. Settings should be available when the thread stops being pending.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D5219_2
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Adding @tomek as blocking since he initially introduced the logic: https://phab.comm.dev/D545
Adding @ashoat as blocking since he pointed out the "discrepancy" between platforms: https://phab.comm.dev/D5082#150392
| native/chat/chat.react.js | ||
|---|---|---|
| 202 ↗ | (On Diff #17097) | Outside the scope of this diff, but might be easier to comprehend if it was more explicit that the one member is the viewer instead of member list sans ashoat having a length of 1 |
Comment Actions
Regarding the test plan, have you checked if the behavior is the same on both platforms?