[native] "Flip the switch" to enable video messages
AbandonedPublic
Actions

Authored by atul on Sep 27 2022, 10:15 AM.

Details

Reviewers

tomek
marcin
• abosh
ashoat

Commits

rCOMMd42be61f11d4: [native] "Flip the switch" to enable video messages

Summary

Now that we have video messages working end-to-end, we can "flip the switch" to enable video messages.

Specifically:

Set serverCanHandle to true for video types in lib/media/file-utils
Set versionCode for hasMinCodeVersion check in multimedia-message-spec to 148
Add MediaLibrary.MediaType.video to mediaType array in multimedia-gallery-keyboard.react so users can select videos from their media gallery

Depends on D5240

Test Plan

All the diffs that came before this one in the stack tested various part of the video message system.

Outside of that I've done a lot of testing on iOS/Android and different codeVersions to make sure that things work as expected... and I'm going to do a lot more before I land this diff.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 27 2022, 10:15 AM

remove some extraneous comments

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 27 2022, 10:25 AM

Harbormaster failed remote builds in B12469: Diff 17116!

Harbormaster failed remote builds in B12470: Diff 17117!

Harbormaster completed remote builds in B12470: Diff 17117.Sep 27 2022, 12:55 PM

atul requested review of this revision.Sep 27 2022, 12:55 PM

Harbormaster completed remote builds in B12469: Diff 17116.Sep 27 2022, 12:55 PM

tomek accepted this revision.Sep 28 2022, 10:17 AM

tomek added inline comments.

lib/shared/messages/multimedia-message-spec.js
207 ↗	(On Diff #17117)	I'm not sure if this is a good idea. We should probably keep it high and then set the proper version just before the release. The reason is that we might want some more releases (e.g. with bugfixes) before we decide to make this feature live. So at this point it is hard to say if `148` will be the release that introduces this feature, or maybe some later would do that.

This revision is now accepted and ready to land.Sep 28 2022, 10:17 AM

atul added inline comments.Sep 28 2022, 10:44 AM

lib/shared/messages/multimedia-message-spec.js
207 ↗	(On Diff #17117)	Yeah you're right, I was going to change it before landing (was planning on landing right when I planned on making a release)... but you're right that I might forget update and other releases may be made. Added a big bold notice at the top of the diff description as a reminder.