Page MenuHomePhabricator
Differential D5258

[native/keyserver] add `source` param on log in from native
ClosedPublic
Actions

Authored by kamil on Sep 29 2022, 3:50 AM.
Tags
None
Referenced Files
F3401163: D5258.diff
Mon, Dec 2, 10:49 AM
Unknown Object (File)
Mon, Nov 25, 10:27 PM
Unknown Object (File)
Mon, Nov 25, 10:27 PM
Unknown Object (File)
Mon, Nov 25, 10:27 PM
Unknown Object (File)
Mon, Nov 25, 7:56 PM
Unknown Object (File)
Fri, Nov 8, 3:17 AM
Unknown Object (File)
Oct 25 2024, 2:49 PM
Unknown Object (File)
Oct 25 2024, 5:51 AM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMMf6382b311477: [native/keyserver] add `source` param on log in from native
Summary

Add indication if login comes directly from native UI.

Additionally: I moved spreading ...extraInfo, to the first place because I believe it's unsafe (it might override some important fields when extraInfo will change).

Test Plan
  1. Log request input here
  2. Log in from the native app
  3. Check if the source was properly received

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 29 2022, 3:50 AM
kamil held this revision as a draft.
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptSep 29 2022, 3:51 AM
Harbormaster completed remote builds in B12515: Diff 17176.Sep 29 2022, 4:00 AM
kamil edited the summary of this revision. (Show Details)Sep 29 2022, 4:11 AM
kamil edited the test plan for this revision. (Show Details)
kamil added a reviewer: atul.
kamil edited the summary of this revision. (Show Details)Sep 29 2022, 4:14 AM
kamil added a parent revision: D5257: [web/keyserver] add `source` param on log in from web.Sep 29 2022, 4:16 AM
kamil added a child revision: D5259: [web/native/lib] make `source` param required on log in.Sep 29 2022, 4:24 AM
kamil published this revision for review.Sep 29 2022, 4:43 AM
ashoat accepted this revision.Sep 29 2022, 7:26 AM
This revision is now accepted and ready to land.Sep 29 2022, 7:26 AM
Closed by commit rCOMMf6382b311477: [native/keyserver] add `source` param on log in from native (authored by kamil). · Explain WhyOct 3 2022, 9:03 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf6382b311477: [native/keyserver] add `source` param on log in from native.

Revision Contents
Changeset List

PathSize
native/
account/
14 lines

Diff 17293

View Options

native/account/log-in-panel.react.js

Loading...