Revert erroneous `async` -> `sync`
ClosedPublic
Actions

Authored by marcin on Oct 10 2022, 3:49 AM.

Tags

None

Referenced Files

	F4120152: D5326.diff
	Tue, Feb 18, 6:16 AM

	Unknown Object (File)
	Sat, Feb 15, 3:13 AM

	Unknown Object (File)
	Thu, Feb 13, 10:34 PM

	Unknown Object (File)
	Wed, Feb 12, 9:21 AM

	Unknown Object (File)
	Wed, Feb 12, 9:20 AM

	Unknown Object (File)
	Jan 16 2025, 3:32 AM

	Unknown Object (File)
	Jan 14 2025, 4:54 AM

	Unknown Object (File)
	Jan 14 2025, 12:41 AM

Subscribers

Details

Reviewers

tomek

Commits

rCOMMe8e9556df4da: Revert erroneous `async` -> `sync`

Summary

This differential reverts mistake I made when landing GlobalDBSingleton diff stack. Context: https://phab.comm.dev/D5233 (last comment)

Test Plan

Same as for https://phab.comm.dev/D5233

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-1992

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Oct 10 2022, 3:49 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptOct 10 2022, 3:49 AM

Harbormaster completed remote builds in B12688: Diff 17438.Oct 10 2022, 4:00 AM

marcin requested review of this revision.Oct 10 2022, 4:00 AM

tomek accepted this revision.Oct 10 2022, 4:06 AM

This revision is now accepted and ready to land.Oct 10 2022, 4:06 AM

Closed by commit rCOMMe8e9556df4da: Revert erroneous `async` -> `sync` (authored by marcin). · Explain WhyOct 10 2022, 4:08 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMe8e9556df4da: Revert erroneous `async` -> `sync`.

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm/

GlobalDBSingleton.mm

2 lines

Diff 17438

View Options

native/ios/Comm/GlobalDBSingleton.mm

Revert erroneous `async` -> `sync`ClosedPublicActions