Paths

Table of Contentst

[keyserver] Update loader.mjs for new version of Node
ClosedPublic
Actions

Authored by ashoat on Oct 12 2022, 10:27 AM.

Tags

None

Referenced Files

	F3401210: D5352.id17521.diff
	Mon, Dec 2, 10:57 AM

	F3400857: D5352.diff
	Mon, Dec 2, 9:13 AM

	Unknown Object (File)
	Wed, Nov 27, 1:11 AM

	Unknown Object (File)
	Mon, Nov 25, 10:35 PM

	Unknown Object (File)
	Mon, Nov 25, 10:35 PM

	Unknown Object (File)
	Tue, Nov 19, 4:23 PM

	Unknown Object (File)
	Tue, Nov 19, 4:23 PM

	Unknown Object (File)
	Tue, Nov 19, 4:23 PM

View All Files

Subscribers

• abosh

tomek

Details

Reviewers

rohan
atul

Commits

rCOMM143681278fe6: [keyserver] Update loader.mjs for new version of Node

Summary

Newer versions of Node replace defaultResolve with nextResolve, and make it return a Promise.

Test Plan

I tested this with both Node 16.9 (.nvmrc) and Node 16.17.1. It doesn't break backwards compatibility with the old version of Node, but it introduces compatibility with the new one

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/nodeupgrade

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 12 2022, 10:27 AM

Herald added subscribers: • abosh, tomek. · View Herald TranscriptOct 12 2022, 10:28 AM

Harbormaster completed remote builds in B12753: Diff 17518.Oct 12 2022, 10:38 AM

ashoat requested review of this revision.Oct 12 2022, 10:38 AM

Discussed in our sync

This revision is now accepted and ready to land.Oct 12 2022, 10:39 AM

Closed by commit rCOMM143681278fe6: [keyserver] Update loader.mjs for new version of Node (authored by ashoat). · Explain WhyOct 12 2022, 11:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM143681278fe6: [keyserver] Update loader.mjs for new version of Node.

Revision Contents
Changeset List

Path

Size

keyserver/

loader.mjs

5 lines

Diff 17518

View Options

[keyserver] Update loader.mjs for new version of NodeClosedPublicActions