Paths

Table of Contentst

[yarn] Add `yarn patch` command to `package.json`
ClosedPublic
Actions

Authored by atul on Oct 20 2022, 11:47 AM.

Details

Reviewers

• derek
ashoat
varun

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM566fc62ec3f1: [yarn] Add `yarn patch` command to `package.json`

Summary

Often you need to pull in tagged commits from origin (via git pull --all --tags) before arc patch to ensure that parent commits exist locally.

This isn't really "documented" anywhere and has come up from time to time on Phabricator/Linear/etc.

This yarn patch command should make things a bit more convenient in the future.

Test Plan

Was able to yarn patch D5427 and get @ashoat's full ReactNav stack locally:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D5445 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 11:47 AM

Herald added subscribers: • abosh, tomek. · View Herald TranscriptOct 20 2022, 11:47 AM

🫡

save some buildkites for a sunny day

This revision is now accepted and ready to land.Oct 20 2022, 11:49 AM

atul edited the test plan for this revision. (Show Details)Oct 20 2022, 11:50 AM

atul added a reviewer: varun.

atul added a reviewer: Restricted Owners Package.

This revision now requires review to proceed.Oct 20 2022, 11:51 AM

ashoat accepted this revision.Oct 20 2022, 11:56 AM

This revision is now accepted and ready to land.Oct 20 2022, 11:56 AM

Harbormaster completed remote builds in B12943: Diff 17745.Oct 20 2022, 11:58 AM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 20 2022, 12:07 PM

Closed by commit rCOMM566fc62ec3f1: [yarn] Add `yarn patch` command to `package.json` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM566fc62ec3f1: [yarn] Add `yarn patch` command to `package.json`.

Harbormaster completed remote builds in B12945: Diff 17747.Oct 20 2022, 12:17 PM

tomek added inline comments.Oct 21 2022, 2:00 AM

package.json
20 ↗	(On Diff #17748)	This is really unfortunate name because it might be confused with https://yarnpkg.com/cli/patch

atul added inline comments.Oct 21 2022, 5:43 AM

package.json
20 ↗	(On Diff #17748)	Ah that’s fair, should we rename this to something like `yarn arcpatch` to be more unique?

ashoat added inline comments.Oct 21 2022, 6:10 AM

package.json
20 ↗	(On Diff #17748)	Yeah that seems like a good idea. To be clear, I think the feature @tomek pointed out only exists in Yarn 2 and above ("yarn berry"), whereas we're still using Yarn 1 ("yarn classic")

atul mentioned this in D5455: [yarn] Rename `yarn patch` to `yarn arcpatch`.Oct 21 2022, 11:10 AM

atul marked 2 inline comments as done.

atul added inline comments.

package.json
20 ↗	(On Diff #17748)	Addressed here: https://phab.comm.dev/D5455

atul mentioned this in rCOMMb1f7ecdc14c7: [yarn] Rename `yarn patch` to `yarn arcpatch`.Oct 21 2022, 11:37 AM

Revision Contents
Changeset List

Path

Size

package.json

3 lines

Diff 17747

View Options

[yarn] Add `yarn patch` command to `package.json`ClosedPublicActions