Page MenuHomePhabricator

[native] fix Android build by changing where we get React Native's Android binaries
AbandonedPublicDraft

Authored by varun on Nov 7 2022, 1:36 PM.
Tags
None
Referenced Files
F3360576: D5549.id18163.diff
Sun, Nov 24, 1:29 PM
F3359817: D5549.diff
Sun, Nov 24, 11:03 AM
F3358874: D5549.diff
Sun, Nov 24, 6:30 AM
Unknown Object (File)
Tue, Nov 19, 8:57 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Oct 6 2024, 10:37 PM
Unknown Object (File)
Oct 6 2024, 10:37 PM
Unknown Object (File)
Oct 6 2024, 10:34 PM

Details

Reviewers
ashoat
atul
Summary

What this fix will do is apply an exclusiveContent resolution rule that will force the resolution of React Native Android library to use the one inside node_modules.

Test Plan

successfully built the android app locally

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 1:48 PM
Harbormaster failed remote builds in B13236: Diff 18163!

I came up with this idea after noticing that Gradle was trying to pull react-native for @react-native-community/art from Maven, rather than from node_modules. Turns out D5542 made sure Gradle was looking for a 0.66 version (which shouldn't exist in Maven, and should only exist in node_modules), but Gradle was still checking Maven. The error Varun saw was caused by Gradle getting failures connecting to Maven due to current Maven stability issues... this diff technically "addresses" that by making sure Gradle doesn't check Maven for react-native, but there are other packages Gradle still needs from Maven and so the issues are ultimatly still occurring. So probably no reason to do this?