[services] Tunnelbroker - Add test for the `findSessionItemByDeviceID` function
DraftPublic
Actions

Authored by • max on Nov 17 2022, 2:47 AM.

Details

Reviewers

• jon

Summary

TBD

Test Plan

TBD

Diff Detail

Repository

rCOMM Comm

Branch

add-findSessionItemByDeviceID-test

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Nov 17 2022, 2:47 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptNov 17 2022, 2:47 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.Nov 17 2022, 2:48 AM

• max edited parent revisions, added: D5661: [services] Tunnelbroker - Adding `getSessionItemsByDeviceID` function; removed: D5528: [services] Tunnelbroker - Adding of the client authentication by the `sessionID` from metadata.

Harbormaster failed remote builds in B13506: Diff 18515!Nov 17 2022, 2:49 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

libcpp/

test/

DatabaseManagerTest.cpp

28 lines

Diff 18515

View Options

services/tunnelbroker/src/libcpp/test/DatabaseManagerTest.cpp

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines	async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult;		let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult;		const [, canRequestPermission] = permissionPromisesResult;

if (!hasPermission && canRequestPermission) {		if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => {		const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt		// We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears		// doesn't appear immediately but after logged-out modal disappears
await sleep(10);		await sleep(10);
await this.requestAndroidNotificationsPermission();		return await this.requestAndroidNotificationsPermission();
		marcinUnsubmitted Not Done Inline Actions We definitely should return something from this lambda since otherwise it is useless to assign it to variable. When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android. If we find that we don't have permissions then just calling `await this.requestAndroidNotificationsPermission();` would result in a prompt asking for notifications permissions. However if the user grants those permissions then `hasPermissions` is still falsy (since promise returned nothing), so `deviceToken` will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render. This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state. marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})();		})();
hasPermission = permissionResponse;		hasPermission = permissionResponse;
}		}

if (!hasPermission) {		if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);		this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return;		return;
}		}
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines

[services] Tunnelbroker - Add test for the `findSessionItemByDeviceID` functionDraftPublicActions