[native] Replace hacky call to imported dispatch in intentionalSaveMedia
ClosedPublic
Actions

Authored by ashoat on Nov 18 2022, 5:49 AM.

Details

Reviewers

atul
tomek

Commits

rCOMM2f784d213a1f: [native] Replace hacky call to imported dispatch in intentionalSaveMedia

Summary

While working on D5667, I noticed this hacky dispatch call, and figured it would be good to replace with something more idiomatic.

Test Plan

Test that saving an image from ImageModal still works and generates a report

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/androidNotifIssue

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 18 2022, 5:49 AM

Harbormaster completed remote builds in B13547: Diff 18566.Nov 18 2022, 6:03 AM

ashoat requested review of this revision.Nov 18 2022, 6:03 AM

ashoat added a parent revision: D5667: [native] Stop calling saveMessageInfos from androidBackgroundMessageTask.Nov 18 2022, 6:18 AM

ashoat added a child revision: D5669: [lib] Populate messageStore.threads from threadInfos before setMessageStoreMessages.

ashoat edited the test plan for this revision. (Show Details)Nov 19 2022, 12:05 PM

ashoat added 1 blocking reviewer(s): atul.Nov 20 2022, 7:38 AM

atul accepted this revision.Nov 21 2022, 2:18 PM

This revision is now accepted and ready to land.Nov 21 2022, 2:18 PM

Closed by commit rCOMM2f784d213a1f: [native] Replace hacky call to imported dispatch in intentionalSaveMedia (authored by ashoat). · Explain WhyNov 21 2022, 2:30 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2f784d213a1f: [native] Replace hacky call to imported dispatch in intentionalSaveMedia.

Revision Contents
Changeset List

Path

Size

native/

media/

image-modal.react.js

16 lines

save-media.js

137 lines

Diff 18566

View Options

native/media/image-modal.react.js