Page MenuHomePhabricator
Differential D5671

[lib] Ensure messageStore.threads entry for each message from SQLite
ClosedPublic
Actions

Authored by ashoat on Nov 18 2022, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:38 AM
Unknown Object (File)
Wed, Apr 17, 3:38 AM
Unknown Object (File)
Wed, Apr 17, 3:37 AM
Unknown Object (File)
Wed, Apr 17, 3:34 AM
Unknown Object (File)
Mar 28 2024, 12:06 PM
Unknown Object (File)
Mar 26 2024, 12:51 AM
Unknown Object (File)
Mar 26 2024, 12:51 AM
Unknown Object (File)
Feb 28 2024, 6:14 PM
View All 49 Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMMe08d9578aa70: [lib] Ensure messageStore.threads entry for each message from SQLite
Summary

See 2b here. This diff makes sure that if a message is present in SQLite, we have a messageStore.threads entry for its corresponding thread.

Test Plan

Confirm that issue in ENG-2275 no longer repros

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 18 2022, 6:18 AM
ashoat added a parent revision: D5670: [lib] Introduce newThread helper to message-reducer.js.Nov 18 2022, 6:18 AM
ashoat added a child revision: D5672: [native] Don't call dispatch from reducer.Nov 18 2022, 6:22 AM
Harbormaster completed remote builds in B13550: Diff 18569.Nov 18 2022, 6:31 AM
ashoat requested review of this revision.Nov 18 2022, 6:31 AM
ashoat added a comment.Nov 19 2022, 12:03 PM

Tested this and it works to prevent crash, but the messages are all still lost since when the SAVE_MESSAGES action gets processed it ends up triggering updateMessageStoreWithLatestThreadInfos with an empty ThreadStore and thus generating a remove_messages_for_threads op to delete messages from SQLite. D5667 is still needed to prevent the SAVE_MESSAGES action from firing, but this change is still a good change.

atul accepted this revision.Nov 21 2022, 10:44 AM
This revision is now accepted and ready to land.Nov 21 2022, 10:44 AM
Closed by commit rCOMMe08d9578aa70: [lib] Ensure messageStore.threads entry for each message from SQLite (authored by ashoat). · Explain WhyNov 21 2022, 2:30 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe08d9578aa70: [lib] Ensure messageStore.threads entry for each message from SQLite.

Revision Contents
Changeset List

PathSize
lib/
reducers/
11 lines

Diff 18706

View Options

lib/reducers/message-reducer.js

Loading...