[lib] Ensure messageStore.threads entry for each message from SQLite
ClosedPublic
Actions

Authored by ashoat on Nov 18 2022, 6:18 AM.

Details

Reviewers

atul
tomek

Commits

rCOMMe08d9578aa70: [lib] Ensure messageStore.threads entry for each message from SQLite

Summary

See 2b here. This diff makes sure that if a message is present in SQLite, we have a messageStore.threads entry for its corresponding thread.

Test Plan

Confirm that issue in ENG-2275 no longer repros

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/androidNotifIssue

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 18 2022, 6:18 AM

ashoat added a parent revision: D5670: [lib] Introduce newThread helper to message-reducer.js.Nov 18 2022, 6:18 AM

ashoat added a child revision: D5672: [native] Don't call dispatch from reducer.Nov 18 2022, 6:22 AM

Harbormaster completed remote builds in B13550: Diff 18569.Nov 18 2022, 6:31 AM

ashoat requested review of this revision.Nov 18 2022, 6:31 AM

Tested this and it works to prevent crash, but the messages are all still lost since when the SAVE_MESSAGES action gets processed it ends up triggering updateMessageStoreWithLatestThreadInfos with an empty ThreadStore and thus generating a remove_messages_for_threads op to delete messages from SQLite. D5667 is still needed to prevent the SAVE_MESSAGES action from firing, but this change is still a good change.