Page MenuHomePhabricator
Differential D5887

[keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB
ClosedPublic
Actions

Authored by atul on Dec 16 2022, 12:02 PM.
Tags
None
Referenced Files
F3499624: D5887.diff
Thu, Dec 19, 11:37 PM
Unknown Object (File)
Tue, Dec 10, 1:48 AM
Unknown Object (File)
Thu, Nov 28, 11:55 PM
Unknown Object (File)
Thu, Nov 28, 11:55 PM
Unknown Object (File)
Fri, Nov 22, 5:54 AM
Unknown Object (File)
Fri, Nov 22, 5:54 AM
Unknown Object (File)
Fri, Nov 22, 5:54 AM
Unknown Object (File)
Fri, Nov 22, 5:54 AM
View All Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB
Summary

Introduce createSIWENonceEntry in siwe-nonce-creator and consume in siweNonceResponder to persist nonce entry in DB.

If there is already an existing entry for a given ethereum_address, createSIWENonceEntry will update the current entry in place. However, this may prevent a user from signing in with ethereum on two devices with the same wallet at the same time. We can add a deviceID column to the siwe_nonces column to handle that scenario and create a (deviceID, ethereum_address) composite key or something.

Depends on D5885

Test Plan

nonces generated in response to client hitting siwe_nonce endpoint are persisted in the serverDB:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 16 2022, 12:02 PM
atul published this revision for review.Dec 16 2022, 12:03 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B14209: Diff 19442.Dec 16 2022, 12:14 PM
ashoat accepted this revision.Dec 16 2022, 1:15 PM

Don't land until you connect the nonce to a specific session please

This revision is now accepted and ready to land.Dec 16 2022, 1:15 PM
atul updated this revision to Diff 19448.Dec 17 2022, 3:10 PM

fix

Harbormaster failed remote builds in B14214: Diff 19448!Dec 17 2022, 3:11 PM
Harbormaster completed remote builds in B14214: Diff 19448.Dec 17 2022, 4:11 PM
ashoat requested changes to this revision.Dec 19 2022, 9:23 AM
ashoat added inline comments.
keyserver/src/responders/siwe-nonce-responders.js
12

I think you forgot to update this

This revision now requires changes to proceed.Dec 19 2022, 9:23 AM
atul added inline comments.Dec 19 2022, 9:24 AM
keyserver/src/responders/siwe-nonce-responders.js
12

Ah yeah, looks like I missed that when resolving merge conflicts, thanks for catching that

atul updated this revision to Diff 19684.Dec 19 2022, 10:49 AM

fix issue from incorrectly resolving merge conflict

ashoat accepted this revision.Dec 19 2022, 11:05 AM
This revision is now accepted and ready to land.Dec 19 2022, 11:05 AM
atul updated this revision to Diff 19687.Dec 19 2022, 11:20 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 19 2022, 11:21 AM
Closed by commit rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7daa8a0cb31a: [keyserver] Introduce `createSIWENonceEntry` to persist nonce in DB.
Harbormaster completed remote builds in B14431: Diff 19684.Dec 19 2022, 11:29 AM
Harbormaster completed remote builds in B14434: Diff 19687.Dec 19 2022, 11:35 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
14 lines
responders/
6 lines

Diff 19448

View Options

keyserver/src/creators/siwe-nonce-creator.js

Loading...
View Options

keyserver/src/responders/siwe-nonce-responders.js

Loading...