Page MenuHomePhabricator

[lib] Handle string exception in getMessageForException
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:49 PM.
Tags
None
Referenced Files
F2900274: D5890.diff
Sat, Oct 5, 9:31 AM
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:49 AM
Unknown Object (File)
Mon, Sep 30, 8:48 AM
Unknown Object (File)
Aug 28 2024, 5:35 PM
Unknown Object (File)
Aug 28 2024, 2:22 AM
Unknown Object (File)
Aug 27 2024, 6:53 PM
Subscribers

Details

Summary

Obvious in hindsight. Only noticed this while debugging an issue where this line was seeing a string exception, which I think is coming from react-native-background-upload.

getMessageForException is meant to be a general-purpose utility, so I think it's good for us to handle this.

Test Plan

I confirmed that after this change, the mediaMissionReport sent by commbot included an exceptionMessage property that had the text of the exception

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/rn70-upgrade-extras
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:37 PM
Harbormaster failed remote builds in B14219: Diff 19453!

Something is broken with iOS CI

This revision is now accepted and ready to land.Dec 19 2022, 1:58 AM