Page MenuHomePhabricator

[native] Consider null notification tag in CommNotificationsHandler
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:38 PM.
Tags
None
Referenced Files
F3494271: D5889.id19570.diff
Thu, Dec 19, 4:58 AM
F3493377: D5889.diff
Thu, Dec 19, 3:08 AM
Unknown Object (File)
Sat, Dec 7, 12:44 PM
Unknown Object (File)
Sat, Dec 7, 12:44 PM
Unknown Object (File)
Sat, Dec 7, 12:44 PM
Unknown Object (File)
Sat, Dec 7, 12:31 PM
Unknown Object (File)
Nov 9 2024, 2:32 AM
Unknown Object (File)
Nov 9 2024, 2:31 AM
Subscribers

Details

Summary

I noticed an error while testing my React Native 0.70 branch on Android: https://web.comm.app/upload/3959996/63ded52241732e2f

My guess is that it happened because the "empty notification" generated by react-native-background-upload (context here) does not have a tag.

Either way, the API is clear that this value can be null, so we should check for it.

Test Plan

I tested generating a rescind notif on a client after that client uploaded a message in the background and the issue did not reoccur

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable