[landing] Disable RainbowKit slide-in animation
ClosedPublic
Actions

Authored by ashoat on Dec 22 2022, 4:48 PM.

Details

Reviewers

atul

Commits

rCOMMe385ad79f9f3: [landing] Disable RainbowKit slide-in animation

Summary

Our BottomSheet is already sliding in; we don't need to do it twice.

Test Plan

Load http://localhost:3000/commlanding/siwe in desktop browser, Mobile Safari on Simulator, and within WebView in Comm app to verify slide-in effect is gone

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 22 2022, 4:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 22 2022, 4:48 PM

ashoat added a parent revision: D6009: [native] Let the user dismiss the SIWEPanel with a gesture.Dec 22 2022, 4:49 PM

Harbormaster completed remote builds in B14704: Diff 20046.Dec 22 2022, 5:00 PM

ashoat requested review of this revision.Dec 22 2022, 5:00 PM

ashoat retitled this revision from [landing] Disable SIWE slide-in animation to [landing] Disable RainbowKit slide-in animation.Dec 22 2022, 7:16 PM

atul accepted this revision.Dec 22 2022, 10:37 PM

atul added inline comments.

landing/siwe.css
30	Are we confident that this value is going to be static + remain the same going forward?

This revision is now accepted and ready to land.Dec 22 2022, 10:37 PM

ashoat added inline comments.Dec 23 2022, 6:12 AM

landing/siwe.css
30	Absolutely not – I suspect if we updated RainbowKit we would have to rejigger this. It's sort of like a `patch-package`. I did test a prod build to make sure these hacks work there too, though. I'd like to move away from RainbowKit eventually, but not sure how easy that will be.

Closed by commit rCOMMe385ad79f9f3: [landing] Disable RainbowKit slide-in animation (authored by ashoat). · Explain WhyDec 23 2022, 6:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe385ad79f9f3: [landing] Disable RainbowKit slide-in animation.

atul added inline comments.Dec 23 2022, 1:27 PM

landing/siwe.css
30	I think it might be worth leaving a brief comment explaining where `_9pm4ki5` came from for future readers. I guess they'd be able to figure it out by looking at this diff via `git blame`, but searching the codebase for "_9pm4ki5" doesn't yield any results (I have `node_modules` excluded from search by default).