Differential D6007

[native] Wrap SIWEPanel WebView in BottomSheet
ClosedPublic
Actions

Authored by ashoat on Dec 22 2022, 4:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 7:29 AM

	Unknown Object (File)
	Tue, Nov 5, 7:29 AM

	Unknown Object (File)
	Tue, Nov 5, 7:29 AM

	Unknown Object (File)
	Sat, Nov 2, 7:54 PM

	Unknown Object (File)
	Oct 7 2024, 1:51 AM

	Unknown Object (File)
	Oct 6 2024, 11:14 AM

	Unknown Object (File)
	Oct 6 2024, 11:14 AM

	Unknown Object (File)
	Oct 6 2024, 11:14 AM

Subscribers

Details

Reviewers

Commits

rCOMM98f40f9ff224: [native] Wrap SIWEPanel WebView in BottomSheet

Summary

This is gonna improve the UX a lot. See video in Test Plan (has a few later diffs as well).

Test Plan

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 22 2022, 4:29 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 22 2022, 4:29 PM

ashoat added a child revision: D6008: [native] Put SIWEPanel outside of SafeAreaView.Dec 22 2022, 4:32 PM

ashoat edited the test plan for this revision. (Show Details)Dec 22 2022, 4:35 PM

Harbormaster completed remote builds in B14701: Diff 20043.Dec 22 2022, 4:44 PM

ashoat requested review of this revision.Dec 22 2022, 4:44 PM

atul accepted this revision.Dec 22 2022, 10:35 PM

This revision is now accepted and ready to land.Dec 22 2022, 10:35 PM

Closed by commit rCOMM98f40f9ff224: [native] Wrap SIWEPanel WebView in BottomSheet (authored by ashoat). · Explain WhyDec 23 2022, 6:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM98f40f9ff224: [native] Wrap SIWEPanel WebView in BottomSheet.

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

71 lines

1 line

20 lines

Diff 20059

native/account/siwe-panel.react.js

Loading...

native/package.json

Loading...

yarn.lock

Loading...