Page MenuHomePhabricator
Differential D6069

[native] display alert if register via SIWE fail
ClosedPublic
Actions

Authored by kamil on Dec 28 2022, 6:24 AM.
Tags
None
Referenced Files
F3495732: D6069.diff
Thu, Dec 19, 9:46 AM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Nov 8 2024, 10:02 AM
Unknown Object (File)
Nov 7 2024, 5:55 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM4cc66894c626: [native] display alert if register via SIWE fail
Summary

Context in ENG-2543

Test Plan

Make sure keyserver will throw any error, register via SIWE, check if alert is visible and after click will navigate to login modal.

Diff Detail

Repository
rCOMM Comm
Branch
siwe-stuff
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 28 2022, 6:24 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 28 2022, 6:24 AM
Harbormaster failed remote builds in B14827: Diff 20218!Dec 28 2022, 6:27 AM
kamil edited the summary of this revision. (Show Details)Dec 28 2022, 6:34 AM
Harbormaster completed remote builds in B14827: Diff 20218.Dec 28 2022, 6:39 AM
kamil published this revision for review.Dec 28 2022, 6:39 AM
ashoat accepted this revision.Dec 28 2022, 6:50 AM

Please address comments before landing!!

native/account/siwe-panel.react.js
115 ↗(On Diff #20218)

Let's actually add throw e here so we still fail the request (we want SIWE_AUTH_FAILED action, not SIWE_AUTH_SUCCESS action)

117 ↗(On Diff #20218)

Nit: I would keep the nextMode destructuring here on this line, so it's localized with where it's used. Otherwise I found myself asking "why do we need nextMode?" where it was destructured

This revision is now accepted and ready to land.Dec 28 2022, 6:50 AM
kamil updated this revision to Diff 20227.Dec 28 2022, 7:22 AM

throw error, update destructing

kamil added inline comments.Dec 28 2022, 7:23 AM
native/account/siwe-panel.react.js
115 ↗(On Diff #20218)

thanks for catching this!

Harbormaster completed remote builds in B14835: Diff 20227.Dec 28 2022, 7:36 AM
Closed by commit rCOMM4cc66894c626: [native] display alert if register via SIWE fail (authored by kamil). · Explain WhyDec 28 2022, 7:38 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4cc66894c626: [native] display alert if register via SIWE fail.

Revision Contents
Changeset List

PathSize
native/
account/
34 lines

Diff 20227

View Options

native/account/siwe-panel.react.js

Loading...