Page MenuHomePhabricator
Differential D6139

Export Background Fetch result constants from CommIOSNotifications to JavaScript
ClosedPublic
Actions

Authored by marcin on Jan 2 2023, 6:34 AM.
Tags
None
Referenced Files
F3497392: D6139.id21434.diff
Thu, Dec 19, 7:05 PM
Unknown Object (File)
Thu, Dec 19, 3:32 PM
Unknown Object (File)
Wed, Dec 18, 7:21 PM
Unknown Object (File)
Wed, Dec 18, 7:10 PM
Unknown Object (File)
Wed, Dec 18, 7:09 PM
Unknown Object (File)
Wed, Dec 18, 7:00 PM
Unknown Object (File)
Sat, Dec 14, 4:15 AM
Unknown Object (File)
Sat, Dec 14, 4:15 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMed6c9bbab5a0: Export Background Fetch result constants from CommIOSNotifications to JavaScript
Summary

This differential implements method in CommIOSNotifications that allows JavaScript to use native string constants that describe background fetch result, without direct hardcoding

Test Plan

Log CommIOSNotifications.getConstants() somwhere in JS and examine its content

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2334
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 2 2023, 6:34 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 2 2023, 6:34 AM
marcin added a parent revision: D6072: Export all react-native methods needed to replace rect-native-notifications.Jan 2 2023, 6:39 AM
Harbormaster completed remote builds in B15025: Diff 20503.Jan 2 2023, 6:49 AM
marcin requested review of this revision.Jan 2 2023, 6:49 AM
marcin added a child revision: D6140: Remove all react-native-notifications usages on iOS.Jan 2 2023, 6:50 AM
marcin planned changes to this revision.Jan 2 2023, 8:11 AM

There is a bug - planning changes until resolved.

marcin updated this revision to Diff 20506.Jan 2 2023, 8:43 AM

Fix bug by introducing RCT_CONVERTER

Harbormaster completed remote builds in B15028: Diff 20506.Jan 2 2023, 8:57 AM
marcin added inline comments.Jan 4 2023, 2:08 AM
native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm
53 ↗(On Diff #20506)

This is copied (partially) from Ashoats fork: https://github.com/Ashoat/react-native-notifications/blob/master/RNNotifications/RNNotifications.m#L108. It allows to convert particular strings passed from JavaScript to Objective C enum instances. In order not to directly hardcode those strings in JavaScript we export them as constants in constantsToExport method a couple of lines below.

152 ↗(On Diff #20506)

Explanation why it is necessary: https://reactnative.dev/docs/native-modules-ios#exporting-constants

tomek accepted this revision.Jan 5 2023, 8:35 AM
tomek added inline comments.
native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm
53 ↗(On Diff #20506)

The code is simple and I don't think we can write something significantly different than in the library.

55 ↗(On Diff #20506)

Shouldn't we indent it?

This revision is now accepted and ready to land.Jan 5 2023, 8:35 AM
marcin updated this revision to Diff 21014.Jan 17 2023, 7:25 AM

Rebase

Harbormaster completed remote builds in B15412: Diff 21014.Jan 17 2023, 7:39 AM
marcin updated this revision to Diff 21423.Jan 27 2023, 1:07 AM

Rebase before landing

Harbormaster completed remote builds in B15714: Diff 21423.Jan 27 2023, 1:21 AM
marcin added inline comments.Jan 27 2023, 1:41 AM
native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm
55 ↗(On Diff #20506)

It was formatted this way by clang-format-all.

Closed by commit rCOMMed6c9bbab5a0: Export Background Fetch result constants from CommIOSNotifications to JavaScript (authored by marcin). · Explain WhyJan 27 2023, 1:52 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMed6c9bbab5a0: Export Background Fetch result constants from CommIOSNotifications to JavaScript.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
CommIOSNotifications/
15 lines

Diff 20503

View Options

native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm

Loading...