Page MenuHomePhabricator
Differential D6147

[image-picker] configure iOS microphone privacy permission
AbandonedPublic
Actions

Authored by • adar on Jan 3 2023, 7:56 AM.
Tags
None
Referenced Files
F3251960: D6147.id20560.diff
Fri, Nov 15, 5:59 PM
F3251959: D6147.id20521.diff
Fri, Nov 15, 5:59 PM
Unknown Object (File)
Mon, Nov 4, 8:04 AM
Unknown Object (File)
Mon, Nov 4, 8:02 AM
Unknown Object (File)
Mon, Nov 4, 7:45 AM
Unknown Object (File)
Tue, Oct 29, 1:50 AM
Unknown Object (File)
Sep 29 2024, 7:30 PM
Unknown Object (File)
Sep 29 2024, 7:30 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
bartek
ashoat
Summary

This preliminary diff configures the necessary permissions for expo-image-picker. This one permission, NSMicrophoneUsageDescription is required for iOS devices as expo-image-picker allows users to create new media. I give more detail in this linear task (https://linear.app/comm/issue/ENG-2559/permission-configurations-for-iosandroid)

Depends on https://phab.comm.dev/D6145

Test Plan

Build + run mobile apps, introduces no UI changes so I would like to verify that I haven't also introduced any bugs while doing these first steps. Tested all the media keyboard interactions and camera (sending, uploading, choosing images).

Diff Detail

Repository
rCOMM Comm
Branch
adar/expo-image-picker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• adar created this revision.Jan 3 2023, 7:56 AM
• adar held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 3 2023, 7:56 AM
Harbormaster completed remote builds in B15042: Diff 20521.Jan 3 2023, 8:10 AM
• adar published this revision for review.Jan 3 2023, 10:18 AM
• adar edited the summary of this revision. (Show Details)
ashoat added a reviewer: bartek.Jan 3 2023, 10:48 AM
atul accepted this revision.Jan 3 2023, 10:59 AM

Build + run web app

Think you might've meant native app? Specifically iOS. Accepting assuming that's what you meant + tested.

native/ios/Comm/Info.debug.plist
82–84 ↗(On Diff #20521)

Oops, looks like this was me. Guess I used spaces when this file otherwise uses tabs

This revision is now accepted and ready to land.Jan 3 2023, 10:59 AM
bartek accepted this revision.Jan 3 2023, 1:03 PM
ashoat requested changes to this revision.Jan 3 2023, 1:06 PM

native/ios/Comm/Info.release.plist needs to be configured as well – everyone please keep this in mind going forward when reviewing changes to plists!

This revision now requires changes to proceed.Jan 3 2023, 1:06 PM
atul added a comment.Jan 3 2023, 1:07 PM
In D6147#184458, @ashoat wrote:

native/ios/Comm/Info.release.plist needs to be configured as well – everyone please keep this in mind going forward when reviewing changes to plists!

Ah crap my bad, I have to modify both Info.debug.plist and Info.release.plist for every release we put out so I should've remembered.

• adar updated this revision to Diff 20560.Jan 3 2023, 7:33 PM

added release plist as well

• adar edited the test plan for this revision. (Show Details)Jan 3 2023, 7:40 PM
Harbormaster completed remote builds in B15069: Diff 20560.Jan 3 2023, 7:47 PM
ashoat requested changes to this revision.Jan 4 2023, 5:41 PM

@adar did you notice this diff is now only updating Info.release.plist?

This revision now requires changes to proceed.Jan 4 2023, 5:41 PM
• adar updated this revision to Diff 20632.Jan 5 2023, 12:37 PM
• adar marked an inline comment as done.

do both plists

Harbormaster completed remote builds in B15130: Diff 20632.Jan 5 2023, 12:52 PM
ashoat accepted this revision.Jan 5 2023, 4:23 PM
This revision is now accepted and ready to land.Jan 5 2023, 4:23 PM
• adar mentioned this in D6188: [image-picker] configure privacy permissions on ios.Jan 11 2023, 8:28 AM
• adar requested review of this revision.Jan 11 2023, 11:40 AM
• adar abandoned this revision.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
4 lines

Diff 20560

View Options

native/ios/Comm/Info.release.plist

Loading...