Page MenuHomePhabricator
Differential D6172

[CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`
AbandonedPublic
Actions

Authored by atul on Jan 5 2023, 12:25 AM.
Tags
None
Referenced Files
F3113121: D6172.id20651.diff
Thu, Oct 31, 6:03 PM
F3112334: D6172.id20594.diff
Thu, Oct 31, 5:13 PM
Unknown Object (File)
Tue, Oct 29, 8:45 AM
Unknown Object (File)
Sat, Oct 26, 10:55 PM
Unknown Object (File)
Sat, Oct 26, 10:55 PM
Unknown Object (File)
Sat, Oct 26, 10:55 PM
Unknown Object (File)
Sat, Oct 26, 10:54 PM
Unknown Object (File)
Sat, Oct 26, 10:47 PM
View All Files
Subscribers
marcin

Details

Reviewers
ashoat
tomek
Commits
rCOMMe26110d5b0dc: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`
Summary

Context: https://linear.app/comm/issue/ENG-2601/remove-userid-arg-from-jsi-initializecryptoaccount

Test Plan

Logged return value of initializeCryptoAccount(...) and getUserPublicKey(...) and things remain as expected.

Also went through native SIWE flow and observed that public key was properly stored in the serverDB cookies table.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 5 2023, 12:25 AM
atul published this revision for review.Jan 5 2023, 12:25 AM
Harbormaster completed remote builds in B15099: Diff 20594.Jan 5 2023, 12:36 AM
tomek accepted this revision.Jan 5 2023, 9:18 AM
This revision is now accepted and ready to land.Jan 5 2023, 9:18 AM
ashoat accepted this revision.Jan 5 2023, 4:17 PM
atul updated this revision to Diff 20651.Jan 8 2023, 4:43 PM

rebase before landing

Harbormaster completed remote builds in B15145: Diff 20651.Jan 8 2023, 4:57 PM
Closed by commit rCOMMe26110d5b0dc: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)` (authored by atul). · Explain WhyJan 8 2023, 11:02 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe26110d5b0dc: [CommCoreModule] Remove `userID` argument from `initializeCryptoAccount(...)`.
atul added a reverting change: rCOMM14c06c14a918: Revert "[CommCoreModule] Remove `userID` argument from `initializeCryptoAccount….Jan 9 2023, 11:10 AM
atul reopened this revision.Jan 9 2023, 11:10 AM

This change broke the CryptoTests (which should be added to Buildkite)

This revision is now accepted and ready to land.Jan 9 2023, 11:10 AM
atul abandoned this revision.Feb 27 2023, 11:12 PM
ashoat added a comment.Feb 28 2023, 6:09 AM

We still need to do this, don't we?

ashoat added a subscriber: marcin.Feb 28 2023, 1:53 PM

It looks like this is handled by D6780 now, and @marcin confirmed that it does not break XCode tests (which I assume includes CryptoTests?)

Revision Contents
Changeset List

PathSize
native/
account/
2 lines
cpp/
CommonCpp/
CryptoTools/
4 lines
8 lines
NativeModules/
3 lines
8 lines
_generated/
schema/
2 lines

Diff 20594

View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...