[image-picker] configure privacy permissions on ios
ClosedPublic
Actions

Authored by • adar on Jan 6 2023, 7:39 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM59cd000299ba: [image-picker] configure privacy permissions on ios

Summary

This preliminary diff configures the necessary permissions for expo-image-picker. This one permission, NSMicrophoneUsageDescription is required for iOS devices as expo-image-picker allows users to create new media. I give more detail in this linear task (https://linear.app/comm/issue/ENG-2559/permission-configurations-for-iosandroid)

Test Plan

Build succeeds. Run succeeds.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• adar created this revision.Jan 6 2023, 7:39 AM

• adar held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJan 6 2023, 7:39 AM

(We can probably abandon this)

@ashoat
Can we accept this diff and abandon the other one (D6147) ? That one has two commits pointing to it, while this one only has one commit and has been done properly. Sorry for the inconvenience, I'll hold off on publishing this diff until you can okay this approach.

• adar published this revision for review.Jan 11 2023, 11:41 AM

Not sure why the arc lint + arc unit CI hasn't completed yet, probably not relevant

This revision is now accepted and ready to land.Jan 11 2023, 11:54 AM

This revision was landed with ongoing or failed builds.Jan 11 2023, 12:25 PM

Closed by commit rCOMM59cd000299ba: [image-picker] configure privacy permissions on ios (authored by • adar). · Explain Why

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMM59cd000299ba: [image-picker] configure privacy permissions on ios.