Paths

Table of Contentst

[web] Add `siweButton` to `LogInForm` component
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 9:29 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component

Summary

Doesn't do anything at the moment.

Depends on D6217

Test Plan

Here's how it looks:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 10 2023, 9:29 PM

atul added inline comments.Jan 10 2023, 9:31 PM

web/account/log-in-form.react.js
170	Using this instead of the two-tone SVG used on `native` because it looks better IMO in this context (where it is smaller on the page). Can bring up during discussion with design team.

atul published this revision for review.Jan 10 2023, 9:31 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B15230: Diff 20760.Jan 10 2023, 9:44 PM

atul edited the summary of this revision. (Show Details)Jan 10 2023, 10:29 PM

atul added a parent revision: D6217: [web] Introduce `LoginFormWrapper` component.

atul added a child revision: D6219: [web] Add `<hr />` in `LogInForm` to separate out "password" and SIWE options.

Won't block this on design, but not convinced we need a separate graphic / button style for web...

Let's revisit when discussing design

This revision is now accepted and ready to land.Jan 11 2023, 3:15 AM

Let's revisit when discussing design

Sounds good, will make sure to mention to David

rebase before landing

This revision was landed with ongoing or failed builds.Jan 11 2023, 9:49 PM

Closed by commit rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfa7a753bbe74: [web] Add `siweButton` to `LogInForm` component.

Harbormaster completed remote builds in B15264: Diff 20816.Jan 11 2023, 10:04 PM

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.css

7 lines

log-in-form.react.js

24 lines

Diff 20760

View Options

web/account/log-in-form.css