Paths

Table of Contentst

[web] Display `ConnectButton` after `ConnectModal` flow completes successfully
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 2:54 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully

Summary

Display ConnectButton with wallet info once ConnectModal flow completes successfully and signer (via useSigner() hook) exists.

Depends on D6220

Test Plan

Here's what it looks like:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 10 2023, 2:54 PM

atul published this revision for review.Jan 10 2023, 2:55 PM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

web/account/log-in-form.react.js
243–245	(All of this SIWE stuff will be refactored and moved into its own component later in the stack.)

Harbormaster completed remote builds in B15234: Diff 20765.Jan 10 2023, 3:09 PM

atul added a child revision: D6225: [web] Conditionally display `ConnectButton` once `nonce` received from `keyserver`.Jan 10 2023, 4:58 PM

ashoat accepted this revision.Jan 10 2023, 7:20 PM

ashoat added inline comments.

web/account/log-in-form.react.js
194	Does it not work if you just pass `openConnectModal` here?
243–245	Thanks for calling this out

This revision is now accepted and ready to land.Jan 10 2023, 7:20 PM

atul marked 2 inline comments as done.Jan 11 2023, 2:52 PM

atul added inline comments.

web/account/log-in-form.react.js
194	Ah the `onSIWEButtonClick` callback was supposed to have `openConnectModal && openConnectModal()`... I'll update that

openConnectModal truthiness check

Harbormaster completed remote builds in B15267: Diff 20822.Jan 11 2023, 3:22 PM

Closed by commit rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully (authored by atul). · Explain WhyJan 11 2023, 3:28 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully.

atul added a child revision: D6256: [web] Conditionally display `ConnectButton` once `nonce` received from `keyserver`.Jan 12 2023, 1:14 PM

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.css

7 lines

log-in-form.react.js

37 lines

Diff 20765

View Options

web/account/log-in-form.css