Page MenuHomePhabricator

[web] Display `ConnectButton` after `ConnectModal` flow completes successfully
ClosedPublic

Authored by atul on Jan 10 2023, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 11:08 PM
Unknown Object (File)
Thu, Nov 28, 4:24 AM
Unknown Object (File)
Thu, Nov 28, 4:24 AM
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Thu, Nov 28, 4:23 AM
Unknown Object (File)
Nov 15 2024, 8:08 PM
Unknown Object (File)
Nov 15 2024, 8:07 PM
Unknown Object (File)
Nov 15 2024, 7:35 PM
Subscribers
None

Details

Summary

Display ConnectButton with wallet info once ConnectModal flow completes successfully and signer (via useSigner() hook) exists.


Depends on D6220

Test Plan

Here's what it looks like:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Jan 10 2023, 2:55 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/account/log-in-form.react.js
243–245

(All of this SIWE stuff will be refactored and moved into its own component later in the stack.)

ashoat added inline comments.
web/account/log-in-form.react.js
194

Does it not work if you just pass openConnectModal here?

243–245

Thanks for calling this out

This revision is now accepted and ready to land.Jan 10 2023, 7:20 PM
atul marked 2 inline comments as done.Jan 11 2023, 2:52 PM
atul added inline comments.
web/account/log-in-form.react.js
194

Ah the onSIWEButtonClick callback was supposed to have openConnectModal && openConnectModal()... I'll update that

atul marked an inline comment as done.

openConnectModal truthiness check