In the course of work on react-native-notifications replacement on iOS I used yarn clang-format-all and it happened to format one Java file i didn't touch.
Details
Details
Without applying this diff run yarn clang-format-all and ensure created changes are equal to this differential
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Ah yeah, this is my fault. I disabled precommit hooks while working on my React Native stack due to Flow errors, which also meant that clang-format didn't get called.
Separately – running yarn clang-format-all is generally an anti-pattern (similar to running eg. eslint --fix .), since our precommit hooks should format things automatically. Was there anything that the precommit hooks were missing? Or maybe you were using git commit --no-verify or otherwise disabling precommit hooks while developing?
Comment Actions
Our pre-commit hooks neither miss anything nor were I using git commit --no-verify. I run yarn clang-format-all frequently during coding since it makes code more readable and comfortable to work with.
Comment Actions
You should not need to submit any diffs with the results of running that command if precommit hooks are working correctly. That command should result in no changes since precommit hooks make sure all code is formatted correctly.