Page MenuHomePhabricator
Differential D6221

[web] Display `ConnectButton` after `ConnectModal` flow completes successfully
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 3:33 PM
Unknown Object (File)
Sun, Nov 10, 10:53 AM
Unknown Object (File)
Tue, Nov 5, 4:28 AM
Unknown Object (File)
Sun, Nov 3, 3:37 PM
Unknown Object (File)
Sun, Nov 3, 1:30 AM
Unknown Object (File)
Sun, Nov 3, 1:30 AM
Unknown Object (File)
Sun, Nov 3, 1:30 AM
Unknown Object (File)
Sun, Nov 3, 1:30 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully
Summary

Display ConnectButton with wallet info once ConnectModal flow completes successfully and signer (via useSigner() hook) exists.

Depends on D6220

Test Plan

Here's what it looks like:

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6221 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 10 2023, 2:54 PM
atul published this revision for review.Jan 10 2023, 2:55 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
web/account/log-in-form.react.js
243–245 ↗(On Diff #20765)

(All of this SIWE stuff will be refactored and moved into its own component later in the stack.)

Harbormaster completed remote builds in B15234: Diff 20765.Jan 10 2023, 3:09 PM
atul added a child revision: D6225: [web] Conditionally display `ConnectButton` once `nonce` received from `keyserver`.Jan 10 2023, 4:58 PM
ashoat accepted this revision.Jan 10 2023, 7:20 PM
ashoat added inline comments.
web/account/log-in-form.react.js
194 ↗(On Diff #20765)

Does it not work if you just pass openConnectModal here?

243–245 ↗(On Diff #20765)

Thanks for calling this out

This revision is now accepted and ready to land.Jan 10 2023, 7:20 PM
atul marked 2 inline comments as done.Jan 11 2023, 2:52 PM
atul added inline comments.
web/account/log-in-form.react.js
194 ↗(On Diff #20765)

Ah the onSIWEButtonClick callback was supposed to have openConnectModal && openConnectModal()... I'll update that

atul updated this revision to Diff 20822.Jan 11 2023, 3:07 PM
atul marked an inline comment as done.

openConnectModal truthiness check

Harbormaster completed remote builds in B15267: Diff 20822.Jan 11 2023, 3:22 PM
Closed by commit rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully (authored by atul). · Explain WhyJan 11 2023, 3:28 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6649fafa888a: [web] Display `ConnectButton` after `ConnectModal` flow completes successfully.
atul added a child revision: D6256: [web] Conditionally display `ConnectButton` once `nonce` received from `keyserver`.Jan 12 2023, 1:14 PM

Revision Contents
Changeset List

PathSize
web/
account/
7 lines
37 lines

Diff 20822

View Options

web/account/log-in-form.css

Loading...
View Options

web/account/log-in-form.react.js

Loading...