Revert "[keyserver/lib] introuce localID field to sendReactionMessage action and reactionMessageCreationResponder"
ClosedPublic
Actions

Authored by ginsu on Jan 11 2023, 3:39 PM.

Details

Reviewers

atul
tomek
ashoat

Commits

rCOMM24b904db30f8: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action…

Summary

This reverts commit 6e4bd6322ea469a741d206ef147f8bb547d36723. Will create a follow up diff to make localID optional in the input validator

Test Plan

Reverted commit and was able to send message likes on web and native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 11 2023, 3:39 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 11 2023, 3:39 PM

ginsu added reviewers: atul, tomek, ashoat.Jan 11 2023, 3:45 PM

ginsu added a child revision: D6245: [lib/keyserver] make localID optional in the sendReactionMessageRequestInputValidator.Jan 11 2023, 3:51 PM

Harbormaster completed remote builds in B15272: Diff 20828.Jan 11 2023, 3:53 PM

ginsu requested review of this revision.Jan 11 2023, 3:53 PM

We can quickly bring this back, just need to make sure localID is optional on the keyserver side

This revision is now accepted and ready to land.Jan 11 2023, 3:54 PM

Closed by commit rCOMM24b904db30f8: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action… (authored by ginsu). · Explain WhyJan 11 2023, 7:51 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM24b904db30f8: Revert "[keyserver/lib] introuce localID field to sendReactionMessage action….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

message-responders.js

4 lines

lib/

actions/

message-actions.js

1 line

Diff 20835

View Options

keyserver/src/responders/message-responders.js