[web] Rename `siweConnectButton` to `siweLoginForm`
ClosedPublic
Actions

Authored by atul on Jan 18 2023, 6:26 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMfdb5cad7fd47: [web] Rename `siweConnectButton` to `siweLoginForm`

Summary

Simple rename. In addition to the ConnectButton, we'll also be including some copy and a "Sign in" button.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 18 2023, 6:26 PM

atul published this revision for review.Jan 18 2023, 6:26 PM

There were more changes in this diff that I moved around to other commits... so at some point it made sense to be its own diff, but should've just squashed this with D6304

ashoat accepted this revision.Jan 18 2023, 6:38 PM

This revision is now accepted and ready to land.Jan 18 2023, 6:38 PM

Harbormaster completed remote builds in B15444: Diff 21056.Jan 18 2023, 6:40 PM

Closed by commit rCOMMfdb5cad7fd47: [web] Rename `siweConnectButton` to `siweLoginForm` (authored by atul). · Explain WhyJan 18 2023, 11:04 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMfdb5cad7fd47: [web] Rename `siweConnectButton` to `siweLoginForm`.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe.react.js

8 lines

Diff 21056

View Options

web/account/siwe.react.js

	#include "ClientGetReadReactor.h"			#include <grpc/ClientGetReadReactor.h>

	ClientGetReadReactor::ClientGetReadReactor(			ClientGetReadReactor::ClientGetReadReactor(
	tunnelbroker::TunnelbrokerService::Stub *stub,			tunnelbroker::TunnelbrokerService::Stub *stub,
	std::string sessionID)			std::string sessionID)
	: sessionID{sessionID}, request{} {			: sessionID{sessionID}, request{} {
	request.set_sessionid(sessionID);			request.set_sessionid(sessionID);
	stub->async()->Get(&(this->context), &(this->request), this);			stub->async()->Get(&(this->context), &(this->request), this);
	StartRead(&(this->response));			StartRead(&(this->response));
	▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

[web] Rename `siweConnectButton` to `siweLoginForm`ClosedPublicActions