Page MenuHomePhabricator

[keyserver] Automatically create daily update threads
ClosedPublic

Authored by ashoat on Jan 21 2023, 3:24 PM.
Tags
None
Referenced Files
F3353233: D6334.diff
Sat, Nov 23, 8:57 AM
Unknown Object (File)
Tue, Nov 12, 12:25 AM
Unknown Object (File)
Fri, Nov 8, 2:57 AM
Unknown Object (File)
Fri, Nov 8, 2:56 AM
Unknown Object (File)
Fri, Nov 8, 2:56 AM
Unknown Object (File)
Tue, Oct 29, 9:52 PM
Unknown Object (File)
Tue, Oct 29, 9:52 PM
Unknown Object (File)
Tue, Oct 29, 9:52 PM
Subscribers

Details

Summary

This way we don't need a human manually setting it up every time.

Depends on D6333

Test Plan

I deployed this to my keyserver in production and tested with patches like this where I:

  1. Overrode the cron time to get it to run when I wanted
  2. Overrode the current date to test how it would work on specific dates
  3. Made it create test threads in a channel nobody else could see

I tested the following scenarios:

  1. Script runs on Monday and there is no event in calendar (thread was not created)
  2. Script runs on Monday and there is an event in calendar indicating dev sync is on Tuesday (thread was created)
  3. Script runs on Tuesday and there is no event in calendar (thread was created)
  4. Script runs on Tuesday and there is an event in calendar indicating dev sync is on Tuesday (thread was not created)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/src/cron/cron.js
65 ↗(On Diff #21168)

The system time zone changed when I moved the keyserver to my personal keyserver to an AWS instance, but this comment wasn't updated

lib/types/filter-types.js
17 ↗(On Diff #21168)

Noticed this and figured I'd fix, should be no problems if no Flow errors

This revision is now accepted and ready to land.Jan 22 2023, 4:10 PM