Paths

Table of Contentst

[web/lib] put logic for creating message reaction list in reaction utils
AbandonedPublic
Actions

Authored by ginsu on Jan 23 2023, 9:46 AM.

Details

Reviewers

atul
tomek

Summary

This logic will be used in both message reaction modals in web and native so we should make a new function in lib to abstract it

Linear Task: ENG-2719
Depends on D6302

Test Plan

flow and the message reaction modal works just as it did before

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 23 2023, 9:46 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 23 2023, 9:46 AM

Harbormaster completed remote builds in B15545: Diff 21206.Jan 23 2023, 10:00 AM

ginsu requested review of this revision.Jan 23 2023, 10:00 AM

ginsu edited the summary of this revision. (Show Details)Jan 23 2023, 10:04 AM

ginsu added reviewers: atul, tomek.

ginsu added a parent revision: D6318: [web] implement new InlineEngagement design.

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D6302: [web/lib] introduce MessageReactionsModal.

ginsu added a child revision: D6350: [native] introduce MessageReactionsModal.Jan 23 2023, 10:19 AM

rebase

Harbormaster completed remote builds in B15566: Diff 21228.Jan 23 2023, 12:00 PM

Probably could've just been merged with D6302

Merged with D6302

Revision Contents
Changeset List

Path

Size

lib/

shared/

reaction-utils.js

55 lines

web/

modals/

chat/

message-reactions-modal.react.js

39 lines

Diff 21206

View Options

lib/shared/reaction-utils.js