introduce MessageReactionsModal. MessageReactionsModal shows all the users who have reacted to a message, what their username is and what reaction they used. I decided to punt the implementation of the filter buttons at the top of the design since every message will be a like for the moment
Details
Details
- Reviewers
atul tomek - Commits
- rCOMM4f331467faf7: [native] introduce MessageReactionsModal
Please watch the demo video to see how MessageReactionsModal works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Overall looks super clean!
Two suggestions inline, let's definitely do the the memoization one before landing.
| native/chat/message-reactions-modal.react.js | ||
|---|---|---|
| 62 | Let's memoize this... otherwise the object (in this case an array) will get recreated every time | |
| 86–88 | Instead of all of these (and marginTop on line 90) can we just do margin: 0, ? | |
| native/chat/message-reactions-modal.react.js | ||
|---|---|---|
| 86–88 | Unfortunately, we do need to set each margin property individually since the modal component sets them individually as well, and margin: 0, won't override those properties in the modal component | |
| native/chat/message-reactions-modal.react.js | ||
|---|---|---|
| 86–88 | Ah gotcha... could you group marginTop with these threes and add a comment saying we need to list them out explicitly to override? | |