Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Surprised to see changes to react-native-flipper@^0.164.0 entry in yarn.lock. When I patched in this diff and ran yarn cleaninstall, it looks like it reverted those changes:
Maybe @ashoat or @tomek have context on what might be happening here?
The repo looks well maintained and license looks good (MIT).
| yarn.lock | ||
|---|---|---|
| 18924–18927 | ||
Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?
The fact that ethers was repositioned in package.json makes me suspect you added emoji-mart via yarn add {dependency} command? There's some weirdness associated with using that command (something to do with our monorepo setup, I don't remember), could you try adding the emoji-mart entries to package.json manually and then running yarn cleaninstall?
Are you using yarn add {dependency} workflow or are you making the addition to package.json manually?
Was using the yarn add {dependency} workflow, will try the other method
Wonder if you just ran yarn cleaninstall from the root of the repo if things would get fixed up?
Wonder if you just ran yarn cleaninstall from the root of the repo if things would get fixed up?
Just tried this and the uid for react-native-flipper is still getting removed, but the version is still staying the same. Will keep investigating
(Went ahead and added @ashoat as blocking since we'll need to do that once the feedback is addressed anyways.)
It's an annoying Yarn bug, I'm aware but not sure how to solve. I think Yarn ignores the root package.json Yarn resolution when running a command in a child repo. I don't remember for sure but I don't think the Yarn resolution worked in native/package.json, but we could try putting it in both of them
| yarn.lock | ||
|---|---|---|
| 18926 ↗ | (On Diff #21278) | I've noticed this change too recently |