Page MenuHomePhabricator
Differential D6406

[web][landing] Add legal acknowledgements to SIWE flow
ClosedPublic
Actions

Authored by atul on Jan 26 2023, 2:15 PM.
Tags
None
Referenced Files
F3203717: D6406.diff
Sat, Nov 9, 8:12 PM
Unknown Object (File)
Tue, Oct 29, 7:54 PM
Unknown Object (File)
Tue, Oct 29, 7:54 PM
Unknown Object (File)
Tue, Oct 29, 7:54 PM
Unknown Object (File)
Tue, Oct 29, 7:54 PM
Unknown Object (File)
Tue, Oct 29, 7:51 PM
Unknown Object (File)
Sat, Oct 19, 7:43 AM
Unknown Object (File)
Oct 3 2024, 5:38 AM
View All 57 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
kamil
Commits
rCOMM7ec720ec655e: [web][landing] Add legal acknowledgements to SIWE flow
Summary

Context: https://linear.app/comm/issue/ENG-2835/disable-auto-accepting-policies-after-siwe
Add Terms of Use and Privacy Policy acknowledment to SIWE flow.

Test Plan

Looks as expected:

Simulator Screen Shot - iPhone 14 Pro - 2023-01-26 at 18.01.31.png (2×1 px, 1 MB)

ded795.png (1×1 px, 217 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6406 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 26 2023, 2:15 PM
Harbormaster completed remote builds in B15692: Diff 21397.Jan 26 2023, 2:30 PM
atul requested review of this revision.Jan 26 2023, 2:30 PM
ashoat added a comment.Jan 26 2023, 2:53 PM

Does it fit on native without resizing the bottom sheet? Can you add screenshots?

atul added a comment.Jan 26 2023, 3:02 PM

Legal agreements do fit on screen. The button, however, does not. In subsequent diff I cut down width of ConnectButton (by reducing characters). In another I reduce the spacing below the ConnectButton so everything fits.

Simulator Screen Shot - iPhone 14 Pro - 2023-01-26 at 18.01.31.png (2×1 px, 1 MB)

atul edited the test plan for this revision. (Show Details)Jan 26 2023, 3:03 PM
ashoat accepted this revision.Jan 26 2023, 5:41 PM
This revision is now accepted and ready to land.Jan 26 2023, 5:41 PM
atul updated this revision to Diff 21475.Jan 27 2023, 12:36 PM

rebase and land

This revision was landed with ongoing or failed builds.Jan 27 2023, 12:37 PM
Closed by commit rCOMM7ec720ec655e: [web][landing] Add legal acknowledgements to SIWE flow (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7ec720ec655e: [web][landing] Add legal acknowledgements to SIWE flow.
Harbormaster completed remote builds in B15751: Diff 21475.Jan 27 2023, 12:50 PM

Revision Contents
Changeset List

PathSize
landing/
5 lines
web/
account/
5 lines

Diff 21475

View Options

landing/siwe.react.js

Loading...
View Options

web/account/siwe.react.js

Loading...