[web] Include `primaryIdentityPublicKey` in SIWE message
ClosedPublic
Actions

Authored by atul on Jan 26 2023, 4:34 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM43573fdca59e: [web] Include `primaryIdentityPublicKey` in SIWE message

Summary

Include primaryIdentityPublicKey from olm in the SIWE message as we do on native. Note that this diff just includes getting the primaryIdentityPublicKey from olm and including it to the SIWE message statement.

NOTE: Persistence of the primaryIdentityPublicKey will happen in a subsequent diff.

Test Plan

Works as expected, can see that the primaryIdentityPublicKey is included in the SIWE message and everything is validated on the keyserver side!

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 26 2023, 4:34 PM

atul edited the test plan for this revision. (Show Details)Jan 26 2023, 4:36 PM

atul edited the summary of this revision. (Show Details)

atul published this revision for review.Jan 26 2023, 4:40 PM

atul added inline comments.

web/account/siwe.react.js
86–94 ↗	(On Diff #21405)	Why aren't we checking if the user intends to go through the SIWE flow or not like we do with `siweNonce`??? The plan is to include the `primaryIdentityPublicKey` for both "traditional" and SIWE log in requests in the future, so just making it available now (very minimal overhead).