[lib] Store expirationTime instead of cacheInsertionTime in ENSCache
ClosedPublic
Actions

Authored by ashoat on Feb 3 2023, 12:32 AM.

Details

Reviewers

Commits

rCOMM0098e9be8425: [lib] Store expirationTime instead of cacheInsertionTime in ENSCache

Summary

This will allow us to vary the cache timeout for different kinds of values. I want to make failed fetches (due to network issues, not due to nonexistant ENS name) expire more quickly than successful ones.

Test Plan

Playing around with ENS on native and web

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 3 2023, 12:32 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 12:32 AM

ashoat added a child revision: D6551: [lib] Catch exceptions thrown by ethers.js in ENSCache.Feb 3 2023, 12:33 AM

Harbormaster completed remote builds in B16057: Diff 21931.Feb 3 2023, 12:44 AM

ashoat requested review of this revision.Feb 3 2023, 12:44 AM

atul accepted this revision.Feb 3 2023, 11:54 AM

This revision is now accepted and ready to land.Feb 3 2023, 11:54 AM

Closed by commit rCOMM0098e9be8425: [lib] Store expirationTime instead of cacheInsertionTime in ENSCache (authored by ashoat). · Explain WhyFeb 5 2023, 7:53 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0098e9be8425: [lib] Store expirationTime instead of cacheInsertionTime in ENSCache.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.js

20 lines

Diff 21931

View Options

[lib] Store expirationTime instead of cacheInsertionTime in ENSCacheClosedPublicActions