Page MenuHomePhabricator
Differential D6592

[web] Use threadUIName instead of robotextName in ThreadSettingsModal
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:24 PM.
Tags
None
Referenced Files
F3501947: D6592.id22005.diff
Fri, Dec 20, 3:52 AM
F3498890: D6592.diff
Thu, Dec 19, 9:50 PM
Unknown Object (File)
Wed, Dec 11, 9:09 PM
Unknown Object (File)
Tue, Dec 3, 4:30 AM
Unknown Object (File)
Sun, Dec 1, 9:08 AM
Unknown Object (File)
Nov 14 2024, 8:21 PM
Unknown Object (File)
Nov 14 2024, 8:21 PM
Unknown Object (File)
Nov 14 2024, 8:21 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal
Summary

I'm about to deprecate robotextName. This diff updates ThreadSettingsModal to figure out a placeholder by resolving a version of the ThreadInfo without the name set.

Depends on D6591

Test Plan

Open and play around with ThreadSettingsModal, clear name to see placeholder

Screenshot 2023-02-04 at 9.45.30 PM.png (1×1 px, 174 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 6:24 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 6:24 PM
ashoat added a child revision: D6593: [native] Fetch ENS names for ThreadInfo uiName in Entry.Feb 4 2023, 6:25 PM
Harbormaster completed remote builds in B16113: Diff 22005.Feb 4 2023, 6:40 PM
ashoat requested review of this revision.Feb 4 2023, 6:40 PM
ashoat updated this revision to Diff 22029.Feb 4 2023, 6:41 PM

Make sure ThreadInfo.name isn't set when calling threadUIName

ashoat updated this revision to Diff 22030.Feb 4 2023, 6:44 PM

Revert accidental web/package.json change

ashoat edited the test plan for this revision. (Show Details)Feb 4 2023, 6:45 PM
Harbormaster completed remote builds in B16137: Diff 22029.Feb 4 2023, 7:53 PM
Harbormaster completed remote builds in B16138: Diff 22030.Feb 4 2023, 7:57 PM
atul accepted this revision.Feb 5 2023, 10:45 AM
This revision is now accepted and ready to land.Feb 5 2023, 10:45 AM
Closed by commit rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal (authored by ashoat). · Explain WhyFeb 5 2023, 12:34 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM6c15cb4c3535: [web] Use threadUIName instead of robotextName in ThreadSettingsModal.

Revision Contents
Changeset List

PathSize
lib/
shared/
1 line
web/
modals/
threads/
settings/
20 lines

Diff 22077

View Options

lib/shared/thread-utils.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...