Use the same ConnectedWalletInfo from web on landing to match styling.
Details
Details
Looks as expected (there's obviously additional work to do here):
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
landing/reset.css | ||
---|---|---|
4–11 | Idk what this is, but it was messing with my ConnectedWalletInfo layout. Removing it didn't seem to break anything on landing (did a quick scan of most pages) |
landing/reset.css | ||
---|---|---|
4–11 | This is a pretty significant change Honestly box-sizing: border-box is a better default than content-box I'd rather see you add box-sizing: border-box to your component and make this explicit on web, and then adjust it to look right If you feel strongly about preferring box-sizing: content-box, we should at least add git grep width and git grep height to the Test Plan, and look for any place that has a border or padding defined |
lib/components/connected-wallet-info.css | ||
---|---|---|
22 ↗ | (On Diff #22812) | Not sure why we need this still but it looks like it's not affecting too much |