[keyserver] introduce fetchUnreadNotifs fetcher
AbandonedPublic
Actions

Authored by ginsu on Feb 8 2023, 11:13 PM.

Details

Reviewers

ashoat
atul
tomek

Summary

introduce the fetchUnreadNotifs fetcher in notifications-fetcher. We want to extract this logic from rescind.js so that we can use it in other situations for example, when we want to rescind an unread reaction message notif when a user unreacts to a message

More context

Linear Task: ENG-2644

Test Plan

This will be further tested in subsequent diffs and there are no clear regressions with rescinding notifs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 8 2023, 11:13 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 8 2023, 11:13 PM

ginsu edited the summary of this revision. (Show Details)Feb 8 2023, 11:15 PM

ginsu added reviewers: ashoat, atul, tomek.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Feb 8 2023, 11:17 PM

ginsu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B16285: Diff 22282.Feb 8 2023, 11:28 PM

ginsu requested review of this revision.Feb 8 2023, 11:28 PM

It's hard to review this without seeing the rest of the stack. Perhaps we should instead fetch this data in the existing SQL query in fetchCollapsableNotifs?

This revision now requires changes to proceed.Feb 9 2023, 8:31 AM

D6830 makes this diff no longer relevant

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

notification-fetchers.js

48 lines

push/

rescind.js

48 lines

Diff 22282

View Options

keyserver/src/fetchers/notification-fetchers.js