Page MenuHomePhabricator
Differential D6672

[native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`
ClosedPublic
Actions

Authored by atul on Feb 9 2023, 11:27 AM.
Tags
None
Referenced Files
F3246886: D6672.id22312.diff
Fri, Nov 15, 2:18 AM
Unknown Object (File)
Tue, Oct 29, 3:36 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 12:30 PM
Unknown Object (File)
Tue, Oct 22, 3:19 AM
Unknown Object (File)
Tue, Oct 22, 3:19 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM0130008ef475: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`
rCOMMca051873c252: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`
Summary

Make JSI call and get primaryIdentityPublicKey before enabled LogInPanel inputs/buttons.

Test Plan

Logged public key as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul updated this revision to Diff 22308.Feb 9 2023, 11:27 AM
atul created this revision.

fix

Harbormaster completed remote builds in B16308: Diff 22308.Feb 9 2023, 11:43 AM
atul requested review of this revision.Feb 9 2023, 11:43 AM
Harbormaster completed remote builds in B16307: Diff 22307.Feb 9 2023, 11:43 AM
ashoat accepted this revision.Feb 9 2023, 11:49 AM
ashoat added inline comments.
native/account/log-in-panel.react.js
61 ↗(On Diff #22308)

This isn't an "async function that hits server APIs" – maybe we should just remove those comments?

This revision is now accepted and ready to land.Feb 9 2023, 11:49 AM
atul added inline comments.Feb 9 2023, 11:55 AM
native/account/log-in-panel.react.js
61 ↗(On Diff #22308)

Yeah without newlines splitting the Props into "chunks," I just assumed the comments referred to the prop immediately below.

I'll remove the comments since I don't think they're particularly useful.

atul updated this revision to Diff 22310.Feb 9 2023, 11:59 AM

rebase + land

Harbormaster completed remote builds in B16310: Diff 22310.Feb 9 2023, 12:14 PM
Closed by commit rCOMMca051873c252: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel` (authored by atul). · Explain WhyFeb 9 2023, 12:21 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMca051873c252: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`.
atul added a reverting change: rCOMM370d665778cc: Revert "[native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`".Feb 9 2023, 12:37 PM
atul reopened this revision.Feb 9 2023, 12:38 PM

accidentally stashed changes responding to feedback instead of amending to commit..

This revision is now accepted and ready to land.Feb 9 2023, 12:38 PM
atul updated this revision to Diff 22312.Feb 9 2023, 12:40 PM

rebase

atul updated this revision to Diff 22313.Feb 9 2023, 12:40 PM

remove comments + land

This revision was landed with ongoing or failed builds.Feb 9 2023, 12:41 PM
Closed by commit rCOMM0130008ef475: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM0130008ef475: [native] Get `primaryIdentityPublicKey` before enabling `LogInPanel`.
Harbormaster completed remote builds in B16311: Diff 22312.Feb 9 2023, 12:55 PM
Harbormaster completed remote builds in B16312: Diff 22313.

Revision Contents
Changeset List

PathSize
native/
account/
21 lines

Diff 22307

View Options

native/account/log-in-panel.react.js

Loading...